I believe the patches applied from http://drupal.org/node/83234 introduce a bug that breaks the globalredirect module as described here http://drupal.org/node/89600. Basically, it is trying to find any alias assigned to the currently requested page and issue a redirect to the alias. The problem is that drupal_lookup_path() no longer returns the alias for the current page, returning FALSE instead.

This problem probably exists in HEAD as well, but I don't have an installation on which to confirm that.

CommentFileSizeAuthor
#3 no_alias_for_current.patch.txt514 bytesheine

Comments

RayZ’s picture

RayZ commented
Version: 4.7.3 » x.y.z

Sorry, this is in the latest 4.7 (and probably 5) cvs not 4.7.3.

chx’s picture

chx commented
Version: x.y.z » 4.7.4

Can't repro on HEAD.

heine’s picture

heine commented
Status: Active » Needs review
StatusFileSize
new no_alias_for_current.patch.txt514 bytes
heine’s picture

heine commented
Version: 4.7.4 » x.y.z

Actually, I can reproduce on HEAD. Patch applies to both HEAD and 4.7 CVS.

Steps to reproduce:

Enable path.module, create an alias for node (eg home).

Create a php node, promote to frontpage:

  print check_plain(l('text', 'node'));

The node now displays:
<a href="/node" class="active">text</a> on the homepage
<a href="/home" class="active">text</a> on the node/nid itself

heine’s picture

heine commented
Status: Needs review » Needs work
heine’s picture

heine commented

Ok, the function wrongly caches for example (node as current page)

'node' => false

http://drupal.org/node/65493 contains a patch that also fixes this.

Tobias Maier’s picture

Tobias Maier commented
Status: Needs work » Closed (duplicate)

the patch at http://drupal.org/node/65493 fixes this.
I think it is the best to work together on one patch...
This is the reason why I set this to duplicate