The default key for the 'open' value of the 'Project status search', 'Task status search', and 'Ticket status search domains' is 'inserted,in progress,on hold'. I've edited the 'inserted' value in the various places and I'm trying to update the key for the 'open' value. The field length is now 20 characters long as opposed to the 28 characters that must have allowed the default to be entered. Please increase the allowable length of the field to 40 characters to accommodate adding multiple values names in the key field to create the new search values.
Thank you,
Elise
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | storm--899970-10.patch | 12.35 KB | juliangb |
| #4 | storm--899970-4.patch | 3.5 KB | juliangb |
Comments
Comment #1
juliangb commentedRef: This is the issue that caused the problem: #717174: Increase character limit.
Comment #2
juliangb commentedThe change that is required is to up the max length in stormattribute_form() to 100, and to enlarge the database fields for all storm modules that can reference attributes to 100 too.
The reason that the size was limited to 20 in the previous issue is because otherwise the link for attributes that are linked to a node is broken.
Comment #3
juliangb commentedAccidentally committed a change to the max length already. Will create patch to sort out the database fields.
Comment #4
juliangb commentedIncomplete patch - up to stormorg alphabetically.
Needs to be physically applied for testing too.
Comment #6
juliangb commentedTesting needs to be against dev.
Comment #7
juliangb commented#4: storm--899970-4.patch queued for re-testing.
Comment #9
juliangb commented#4: storm--899970-4.patch queued for re-testing.
Comment #10
juliangb commentedPatch for the bot.
Comment #11
juliangb commentedDue to my current network connection I am unable to test this patch - only have CVS access at the moment.
Would it be possible to test this please and report back?
It should up the storage for all storm attribute keys in the table for each module to 100.
Comment #12
tchurch commentedI've had a quick look and it doesn't resolve my issue (which was closed as duplicate).
My issue is relating to the attribute table itself.
Even though the table has akey of 100, you can't use the full 100.
e.g.
Try to set the key for "Task status search" with value "Open" to a long string (a list of different values) and it doesn't work. I have to go directly to the database to make the change.
These changes are also good as it would bring all attribute related columns into sync with the table.
Comment #13
juliangb commentedIs this definitely on -dev?
From what I can see (http://drupalcode.org/viewvc/drupal/contributions/modules/storm/stormatt..., line 453), #maxlength is set to 100. I'm fairly sure #size just affects the width of the field.
Have I misunderstood something somewhere?
Comment #14
tchurch commentedRe-tested my issue with -dev. Details in #13 seem to 'fix' my issue.
It must have been fixed earlier (with #717174: Increase character limit )
Sorry, I didn't notice that.
Comment #15
juliangb commentedGlad to hear that one is sorted.
This issue is a completion of that issue with the following logic:
- A #maxlength of 20 meant that you could not input the full search attribute keys
- But allowing attribute keys to be longer than 20 meant that they overflowed in some db tables. This issue fixes the db tables so that we're on 100 all round.
The reason I want to include this in the next release is as currently the recent changes introduce a bug.
Comment #16
juliangb commentedTested and committed.