CVS edit link for randallknutson

I would like to add my spaces_node module to the contrib repository. It is a rather simple module that turns a node into a space. Currently spaces has three submodules that define spaces, one for user, one for taxonomy and one for organic groups. the spaces_node module does essentially the same thing but defines a space for each node when viewing the node. This allows all of the power of spaces to be applied to individual nodes. This includes setting contexts, variables and other spaces enabled settings per node. I'm working on a blog post and screenshot that will better demo this. The long and short of it is though that by defining a node as a space, you can control the layout (using conext_layout), blocks and logo and colors (using designkit) are used on each node in a similar fashion to that used in openatrium for groups.

You can see the code for spaces_node on http://github.com/randallknutson/spaces_node

CommentFileSizeAuthor
#1 spaces_node.tar_.gz1.77 KBrandallknutson

Comments

randallknutson’s picture

randallknutson commented
StatusFileSize
new spaces_node.tar_.gz1.77 KB

Here is a copy of the spaces_node module.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Thanks for your application!

Quick question upfront: Why isn't this contributed back to the Spaces project itself instead? Did you ask the maintainer(s) and did they say that it should be a separate project?

randallknutson’s picture

randallknutson commented

I have not yet but I will do so now.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

I am changing status as per previous comment.

randallknutson’s picture

randallknutson commented
Status: Needs work » Active

yhahn, one of the maintainers of the spaces module has responded that they have written similar modules for clients and that this would be better as a separate module.

See the thread here:
http://drupal.org/node/900846

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
randallknutson’s picture

randallknutson commented

Is there any update on this? I've created a webcast demoing this module in action.

http://getlevelten.com/blog/randall-knutson/how-add-drag-and-drop-blocks...

TomDude48’s picture

TomDude48 commented

Randall is one of our developers at LevelTen. I would like him to start co-maintaining some of our modules.

randallknutson’s picture

randallknutson commented

I'd really appreciate some response to this CVS application. Between my module and becoming a co-maintainer on TomDude48's modules, I've got a lot of stuff I'd like to get out but have been waiting on a response here for a while.

Is there anything else I need to do?

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

I'll take a look at the module. I guess I should watch http://getlevelten.com/blog/randall-knutson/how-add-drag-and-drop-blocks... first.

randallknutson’s picture

randallknutson commented

Awesome! Thanks so much.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Reviewed & tested by the community

Well, I'm ashamed to say that I couldn't find any reason this module isn't just fine. There are things I might quibble with (making the space have to have a magic name seems like a support nightmare) but nothing I can see that is in any way outside appropriate Drupal maintainer territory.

I was baffled to find the php4 "var" usage in the plugin, and it would be good to move past that, as it's become a warning in 5.2 and deprecated in 5.3, but I see that that's straight from spaces usage (which surprises me). Of course, D6 core still supports php4, but that doesn't mean contrib has to. You can just put php = 5.2 in the .info file.

As far as making this maintainable, you've done an absolutely fantastic job with the blog post and the screencast. IMO we should be focusing as much on how well maintainers will communicate with their constituency as how good the code is. And you pass with *flying* colors there.

I'd say let's go with it. RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

randallknutson’s picture

randallknutson commented

Awesome. Thanks guys!

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.