Closed (fixed)
Project:
Flag
Version:
6.x-2.x-dev
Component:
Views integration
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Sep 2010 at 03:05 UTC
Updated:
6 Jan 2011 at 14:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
mooffie commented(Of course, it's for D6 as well.)
Comment #2
mooffie commentedThis validate() method doesn't run for existing views. We may also want to make sure such views fail gracefully (one user reports getting a WSOD in this case).
Comment #3
mooffie commentedNate, are you fine with this patch?
This patch is "safe". It doesn't alter existing code. It just adds validation.
(I wasn't clear here: I meant to say that validate() isn't called when a view is merely run. It's called when one saves a view or previews it.)
Comment #4
mooffie commentedI'm marking this a duplicate of #969102: Don't specify a default flag.
Comment #5
mooffie commentedRe-opening this issue.
Comment #6
mooffie commented#994674: Flag does not exist was marked a dup of this issue.
Comment #7
mooffie commentedI'm going to commit the following patch.
What was added?
- Relationships now have a get_flag() method that does validation at "run time".
- query() methods now exit if get_flag() returns NULL. get_flag() prints a message in case of missing flag.
Comment #8
mooffie commentedComment #9
mooffie commentedCommitted.
http://drupal.org/cvs?commit=468574
http://drupal.org/cvs?commit=468578
(Marking this 'critical', as not having this guard results in WSODs.)