(This is for D6 as well.)

'flag.test' has these problems:

- The links should be updated (it's '.../manage/NAME/OP' now).
- 'story' may not exist ('page' should work on both D6/D7).
- [nid] is [node:nid] in D7 (but tokens aren't tested, so this can be ignored).

CommentFileSizeAuthor
#3 flag_test_fixes-d7.patch4.05 KBquicksketch
#1 flag_test_fixes-d6.patch1.56 KBquicksketch
#1 flag_test_fixes-d7.patch2.61 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed
StatusFileSize
new flag_test_fixes-d7.patch2.61 KB
new flag_test_fixes-d6.patch1.56 KB

Even after a year, the ghost of mooffie is still posting valid bugs. ;)

This patch fixes our tests in the 2.x branch for both D6 and D7. Obvious improvements still needed (access checking tests, token tests, etc), but at least gets them passing again.

quicksketch’s picture

quicksketch
he/him
commented
Title: Fix the tests » Fix the existing tests so they pass

More verbose title.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new flag_test_fixes-d7.patch4.05 KB

Sorry the D7 patch actually included token fixes too. Attached is actual committed patch for D7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.