Patch attached

CommentFileSizeAuthor
#12 onepageprofile-alter_by_ref.patch843 bytesfberge
#5 onepageprofile_form_id.notice.patch557 bytesswentel
#2 page_title.notices.patch570 bytesswentel
page_title.patch2.35 KBswentel

Comments

swentel’s picture

swentel commented
Status: Needs review » Needs work

Hrm, one second, seems to be wrong, I'll get back to this.

swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new page_title.notices.patch570 bytes

Ok, first patch was wrong, this one is better.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented

Interesting... When would a form not have an #id?!

swentel’s picture

swentel commented

Hrm, ok did some more debugging and it's actually the fault of the onepageprofile module in onepageprofile_user() where it calls drupal_alter('form') - actually funny looking at that code - http://drupalcode.org/viewvc/drupal/contributions/modules/onepageprofile.... This is obviously more his fault because he's not passing an '#id' here. We should rather file an issue to his module I guess .. :)

swentel’s picture

swentel commented
Project: Page Title » One page profile
Version: 6.x-2.x-dev » 6.x-1.10
StatusFileSize
new onepageprofile_form_id.notice.patch557 bytes

Moving this to one page profile. By calling drupal_alter('form') and not supplying a $form['#id'], a lot of other modules trigger PHP notices. I actually made a fool of myself filing already 3 issues for the same problem before I really started debugging ... :) Anyway patch attached, not sure if the '#id' name is ok, maybe this could be something else.

swentel’s picture

swentel commented
Title: PHP notice in hook_form_alter » PHP notice by not passing $form['#id']

changing title

aidanlis’s picture

aidanlis commented

Good pick up everyone, will get this into the next version.

aidanlis’s picture

aidanlis commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dontgoquietly’s picture

dontgoquietly commented
Status: Closed (fixed) » Needs review

Hi, this error is still occurring with 6.x-1.11. I get the following error:

warning: Parameter 2 to auto_username_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.
warning: Parameter 2 to date_timezone_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.
warning: Parameter 2 to video_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.
warning: Parameter 2 to content_profile_registration_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.
warning: Parameter 2 to taxonomy_defaults_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.
warning: Parameter 2 to multistep_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.
warning: Parameter 2 to rules_forms_form_alter() expected to be a reference, value given in /includes/common.inc on line 2883.

when viewing a user profile.

I checked that $category_form['#id'] = 'profile_form_profile'; was applied to onepageprofile_user().

swentel, you had a question about the #id name. I'm not sure what's happening here, but if you've managed to get this to work, please let me know if this is the same error or if I need to open a new ticket.

Thanks

dontgoquietly’s picture

dontgoquietly commented

It may have something to do with date/timezone module, as disabling that module caused this error to go away. Unfortunately, I need that module, so I can not use onepageprofile as it currently works.

fberge’s picture

fberge commented
StatusFileSize
new onepageprofile-alter_by_ref.patch843 bytes

This is an error with func_get_args() and references
See comments in common.inc

Supplied patch does the trick for me

aidanlis’s picture

aidanlis commented

Wow, nicely found!

fberge’s picture

fberge commented

Should we set the status for this issue to done or something?
Dont know what the practice says, but it bothers me that this ticket is one of my active ones =)

aidanlis’s picture

aidanlis commented

I'll set it to fixed once the patch is in CVS, I should have a chance to go through my patch queue this week.

aharown07’s picture

aharown07 commented
Status: Needs review » Reviewed & tested by the community

Patch "failed"... Applied it manually. Fix works (using D6.20 PHP 5.3.something)
So... will we see this in a new release soon?

carvalhar’s picture

carvalhar commented

#12 patch worked for me.

hk2000’s picture

hk2000 commented
Version: 6.x-1.10 » 6.x-1.11
Priority: Minor » Critical

#12 patch worked for me as well.

I was getting mulitple errors along the lines of:
Parameter 2 to hook_form_alter() expected to be a reference, value given in /var/www/includes/common.inc

It is in regards to the way drupal_alter is called on line 82 of 6.11. Recommend updating to this patch as soon as possible to fix this issue.

aidanlis’s picture

aidanlis commented

Fixed, sorry for the delay in getting this live!

aidanlis’s picture

aidanlis commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.