Closed (outdated)
Project:
Follow
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Sep 2010 at 15:54 UTC
Updated:
18 Apr 2024 at 09:07 UTC
Jump to comment: Most recent
When configuring the the 'Follow Site', the standard Block title field is followed by
Default block title:
() Follow Jessica Purvis Photography on
() Follow me on
() Follow us on
But these options are taking precedence over the standard Block title, making it impossible for us to set our own custom block title.
I would like the ability to enter just "Follow us" or "Follow" or even "", and have that override the default block title options, but no matter what I put in the standard block title field it does not take and the value is missing when I try to edit again.
Comments
Comment #1
q0rban commentedHmm, I can't replicate this. Changing the block title for me works just fine. Can you change titles on other blocks? :)
Comment #2
zach harkey commentedI'm an idiot.
I had the block placed inside a mini-panel but rendering as a system block. All I had to do was override the block's title through the panels pane admin and it recognized.
Sorry for the alarm.
Comment #3
q0rban commentedNo problem, glad you got it figured out. :)
Comment #5
seanrThis is happening for me - edit block, set title to , save, go back to edit and the has disappeared. The module really shouldn't be overriding core behavior in this way. This "feature" really doesn't even add anything all that useful anyway since a user would otherwise be able to type whatever title they wanted, at least for the follow site block.
Comment #6
q0rban commentedI'm not sure what you're referring to. This module doesn't override core behavior at all with regards to block titles. If you are having trouble setting a block title, I would suspect another contrib module to be the culprit, as was the case for Zach above. :)
Comment #7
q0rban commentedComment #8
seanrIt's got to be doing something wrong. This works as expected for all other blocks, but not your module. If I manually set the title in the database, it does appear as expected.
Comment #9
q0rban commentedIf you can give me steps to replicate on a clean Drupal install, I'll definitely look into it. :)
Comment #10
bjc5070 commentedi have the block up and running but for some reason it shows as a text link. I thought it was supposed to be an image link. they module comes with all the social networking logos, so i thought it would show the logo as a link not just the text. did i do something wrong?
Comment #11
q0rban commentedHi @bjc5070, it sounds like you're running into a very different issue. Can you open another issue accordingly? Thanks!
Comment #12
q0rban commentedComment #13
deanflory commentedI too am unable to set a custom block title for the follow site block.
This is indeed an issue and is still an issue 5 years later. Seanr in #8 gives a good clue, that your module is blocking the correct saving of the block title.
I recommend removing the radio buttons with predefined titles and just letting users enter their own custom titles. If they need to use a token for the site name, they can do that themselves, easily.
Comment #14
deanflory commentedChanging the Status back to Active and updating the Version to D7 which could be backported once fixed for D7.
Comment #15
deanflory commentedAlso, whatever you're doing with the Block Title is interfering with the display of the Block Subtitle module.
Comment #16
q0rban commentedHi Dean!
This module is currently minimally maintained. That said, if you have steps to replicate on a clean Drupal install, that would be helpful! :)
Comment #17
deanflory commentedq0rban, above in #6 you state "This module doesn't override core behavior at all with regards to block titles."
Isn't this module responsible for the options when editing a follow block where it offers these options:
There is also still a default 'Block title' field at the top of the block edit form. How then can you state this module doesn't override core behavior? Are those options above, specific to Follow, not from the follow module?
As seanr mentioned FIVE years ago, saving the block form doesn't set the custom title for the block, therefore the follow block prevents custom block titles. It needs to check if anything is entered in the 'Block title' field, if not then it should set it's radio button options (listed above) but also include an option for no title. OR just not offer the 3 options above and interfere with setting a block title.
I don't think explaining the issue further from a clean install standpoint would help clarify this issue any further as multiple people have cited the bug and I've explained it thoroughly. I'd just gut the module of the radio buttons options and let it stand with just the normal Drupal ability to edit the 'Block title' with whatever a user wants to use. You can either maintain the module and get rid of this bug or not.
Clean install:
1) Enable follow
2) edit follow site block on the blocks admin page
3) see the radio buttons and select one, select the first radio button
4) also set a custom title in the 'Block Title' field, something different than any of the 3 radio buttons
5) enable the module to show in a region and save the blocks admin form
6) view the block in a page and note that the radio button choice overrides anything put in the 'Block title' field
7) realize this module provides no option to use a custom block title and that it needs to just remove the functionality of the radio buttons as they are a hinderance to novices and pros alike
Any effort is appreciated, otherwise I'll just have to hack the module (or db as seanr mentioned) to change "Follow us on" to a simple "Follow Us" (faster than all this here).
Comment #18
q0rban commentedHi Dean!
Thanks for responding. :)
Here's the problem. I am unable to replicate the bug on a clean Drupal install. And, no, I have not overridden any core behavior. What core does is allow you to specify a custom block title, and if nothing is set, it will use whatever the module returns. I just tested on a clean install of Drupal with Follow 7.x-2.x and this works exactly as expected. If you enter a custom title, it is used. If not, it uses the one returned by Follow module here: http://cgit.drupalcode.org/follow/tree/follow.module?h=7.x-2.x#n293
You can look at hook_block_view() here to see that nothing fancy is going on in Follow module: https://api.drupal.org/api/drupal/modules%21block%21block.api.php/functi.... All Follow module is doing is returning an array with the subject and block contents. If you enter a custom title on the block in Drupal, Follow doesn't have any control over that. If you are seeing something other than that, it's not Follow module's fault.
If you can give me steps to replicate the issue, I'd be happy to help assist in debugging. Thanks again! :)
Comment #19
deanflory commentedSince this is the only block I'm unable to customize a title for, I'll just have to take seanr's advice and manually update it in the db. Thanks.
Comment #20
astonvictor commentedI'm closing it because the issue was created a long time ago without any further steps.
if you still need it then raise a new one.
thanks