Problem with substr in uc_wishlist.module

I have the same issue. Is there a fix?

I can confirm the same issue...

warning: substr() expects parameter 2 to be long, string given in ...\ubercart\uc_wishlist\uc_wishlist.module on line 420.

Subscribing.

Getting this also
I'm not sure when this message is intended for display
So no idea how to fix it

I just remark the line like this and problem solved
..................
...................
//edit by azul
//if (!substr(request_uri(), 'wishlist', -4)) {
drupal_set_message(t('Your item(s) have been updated.'));
//}
//edit by azul
.............
................

Yes it will solve the problem of the warning appearing
But, as i mentioned previously, it doesn't solve the problem of when the message should be displayed
As now it will always be displayed, which wasn't the intention

I know this hasn't been posted to in over 1 year, but I have this error and am wondering if anyone has resolved this yet?

warning: substr() expects parameter 2 to be long, string given in /....../uc_wishlist/uc_wishlist.module on line 416.

Here is what my file near line 416 looks like. I am using UC Wish List 6.x-1.1:

414:  // Rebuild the items hash
415:  uc_wishlist_get_contents();
416:  if (!substr(request_uri(), 'wishlist', -4)) {
417:    drupal_set_message(t('Your item(s) have been updated.'));
418:  }

I commented out the if statement as mentioned above, but just curious if a proper solution has been found for this.

Thanks
Mike

I am getting the same error too

It seems that the original intention for the code was to set an updated message, but only when on the wishlist page itself.

The entire check and drupal_set_message() call seem redundant, as there is already a different drupal_set_message() call in uc_wishlist_settings_form_submit() which is always called upon submitting the wish list form.

My suggestion would just be to remove this piece of code entirely. Patch attached.

Fixed in latest 6.x-1.x-dev release.

I changed

substr

to

strpos 

for this error.