Because we cannot load modules during the upgrade path but still need to create fields, we need to move all the hook_field_schema() implementations to .install files.

This is a spin-off of #898520: Clean-up the upgrade path: comment.

CommentFileSizeAuthor
#2 902264-move-hook-field-schema-install.patch18.54 KBdamien tournoud
#1 902264-move-hook-field-schema-install.patch17.72 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
Issue tags: +D7 upgrade path
StatusFileSize
new 902264-move-hook-field-schema-install.patch17.72 KB

This should do it.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 902264-move-hook-field-schema-install.patch18.54 KB

One hunk of the previous patch relied on #898520: Clean-up the upgrade path: comment, and chx noted that field.crud.inc now needs to load the install files too.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

This is an important and trivial stepping stone.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. One step closer to making the upgrade path work! :)

Crell’s picture

Crell commented
Issue tags: +API change

Changing where a hook must live is an API change, and should be announced as one.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Trivial testing says to me that this does not affect the normal module workflow. I'm able to enable, uninstall, etc. a module with this in the wrong place.

So is the effect that if your module is in included in an install profile, it would fail on install of a new system?

One of the biggest problems I notice is that the various CCK modules have this in the .module.

damien tournoud’s picture

damien tournoud commented

This is more a best practice kind of thing. hook_field_schema() should, like hook_schema() live in .install. It might work if place somewhere else, but we cannot make any guarantee.

Status: Fixed » Closed (fixed)
Issue tags: -API change, -D7 upgrade path

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +API change, +D7 upgrade path

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.