Note to self: find out what the correct way of managing libraries are in D7 and comply.

If someone has a pointer on this, please share.

CommentFileSizeAuthor
#9 plupload-library-path-902410-9.patch639 byteseffulgentsia
#8 plupload-library-path-902410-8.patch639 byteseffulgentsia
#7 902410-libraries-integration.patch1.77 KBkatbailey

Comments

Jackinloadup’s picture

Jackinloadup commented

Look into using the http://drupal.org/project/libraries module to work with the plupload library.

colemanw’s picture

colemanw commented

For the D6 version you can use the libraries project if you want to. If not, just instruct the user to stick the plupload library in their sites/all/libraries folder.
Please do one or the other. The module folder is a really bad place for it :)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

You should take the approach used by other modules:

  1. Look in sites/all/libraries.
  2. If the library_api module exists and the appropriate APIs are available, use it.
  3. Look in the module's directory.
rickvug’s picture

rickvug commented

Marked #1029190: use sites/all/libraries, not module folder as a duplicate.

effulgentsia’s picture

effulgentsia commented
Assigned: effulgentsia » Unassigned

I forget why I assigned this to me. I may get to it at some point, but it just hasn't been a priority for me. If it is for someone else though, please post a patch.

justintime’s picture

justintime commented

For anyone subscribing to this thread and not to #1029190: use sites/all/libraries, not module folder, I've posted a fix for the D6 version of plupload that needs review over there.

katbailey’s picture

katbailey commented
Status: Active » Needs review
StatusFileSize
new 902410-libraries-integration.patch1.77 KB

Here's a patch based on justintime's D6 solution. I changed the order from what Damien suggested in #3 as it seems to me that if libraries module is enabled, that's the first option it should go with.

effulgentsia’s picture

effulgentsia commented
StatusFileSize
new plupload-library-path-902410-8.patch639 bytes

Thanks for the patch. It helped a lot in me learning what the conventions are. I read the libraries module code, and it doesn't support a library being inside a module folder, and according to the information in http://drupal.org/project/libraries, we probably shouldn't be encouraging that either.

Given that, I think we can just simplify to this 1 line patch. What do you all think? Any objections?

effulgentsia’s picture

effulgentsia commented
StatusFileSize
new plupload-library-path-902410-9.patch639 bytes

Actually, please review this one instead.

effulgentsia’s picture

effulgentsia commented
Status: Needs review » Fixed

Decided to commit #9. Please re-open issue if there are problems with it. I also updated README.txt to reflect that the library will no longer be auto-discovered in the module folder.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 4c7c79d on master, 7.x-2.x, 8.x-1.x by effulgentsia: 
    #902410 by effulgentsia, katbailey: Fixed plupload_library() requires...
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Issue summary: View changes

The project page should reflect this change. I'm not sure if the jQuery loader issue is fixed yet, but the library can be placed in sites/all/libraries now, from what I am reading.