Internal Links in cck, weblinks and links fields are not extracted [#903318]

I've installed CCK Links and Linkchecker (all latest releases) and created a node type with a Link field.

In the Link field I've entered a link to an non existing internal URL in the format of 'node/235'. Note that I've not included the fully qualified domain name. If I place the same link in the body of my node then Linkchecker correctly identifies the link in the body as page not found (404) but does not detect the same issue in the CCK Link field.

In the Linkchecker options I've deselected the option 'Check full qualified domain names only'.

Comment	File	Size	Author
#39	linkchecker_cck_link_non-absolute_url_fails_to_extract2_D7.patch	3.18 KB	hass
#37	linkchecker_cck_link_non-absolute_url_fails_to_extract2.patch	2.94 KB	hass
#35	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	983 bytes	hass
#28	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#27	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#26	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#25	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#24	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#23	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#22	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#21	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#19	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#18	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#17	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#16	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#15	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#14	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#13	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#12	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#11	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#10	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#9	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#8	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#7	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#6	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#2	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes	hass
#1	linkchecker_cck_link_non-absolute_url_fails_to_extract_D6.patch	981 bytes	hass

Comments

Comment #1

hass commented 8 September 2010 at 06:21

Title:	Internal CCK Links are not always reported	» Internal CCK Links are not reported if not absolute urls
Status:	Active	» Needs review

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract_D6.patch	981 bytes

Great catch. Thank you for reporting. Here is a patch.

Comment #2

hass commented 8 September 2010 at 06:22

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Again, other filename for the robot.

Comment #3

hass commented 8 September 2010 at 06:26

This may need to be done for "weblinks" and "links_weblink" input filters, too. Needs more investigation.

Comment #4

8 September 2010 at 06:40

Status:

Needs review

» Needs work

The last submitted patch, linkchecker_cck_link_non-absolute_url_fails_to_extract.patch, failed testing.

Comment #5

hass commented 11 September 2010 at 09:47

Status:

Needs work

» Needs review

#2: linkchecker_cck_link_non-absolute_url_fails_to_extract.patch queued for re-testing.

Comment #6

hass commented 11 September 2010 at 11:34

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

damn buggy testsystem

Comment #7

hass commented 11 September 2010 at 11:50

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #8

hass commented 11 September 2010 at 11:56

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #9

hass commented 11 September 2010 at 23:00

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #10

hass commented 11 September 2010 at 23:11

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #11

hass commented 11 September 2010 at 23:55

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #12

hass commented 11 September 2010 at 23:58

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #13

hass commented 12 September 2010 at 00:18

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #14

hass commented 12 September 2010 at 00:20

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #15

hass commented 12 September 2010 at 00:25

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #16

hass commented 12 September 2010 at 09:47

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #17

hass commented 12 September 2010 at 09:56

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #18

hass commented 12 September 2010 at 10:06

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #19

hass commented 12 September 2010 at 10:17

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #20

tobiasb

German

Berlin

commented 12 September 2010 at 10:21

@hass the patches are all the same. Please have a look at one result http://qa.drupal.org/pifr/test/87629.

Comment #21

hass commented 12 September 2010 at 10:28

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #22

hass commented 12 September 2010 at 10:35

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #23

hass commented 12 September 2010 at 10:47

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #24

hass commented 12 September 2010 at 10:50

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #25

hass commented 12 September 2010 at 11:09

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #26

hass commented 12 September 2010 at 11:16

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #27

hass commented 12 September 2010 at 11:22

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #28

hass commented 12 September 2010 at 11:36

Status	File	Size
new	linkchecker_cck_link_non-absolute_url_fails_to_extract.patch	981 bytes

Comment #29

hass commented 12 September 2010 at 11:41

@tobi: something is rotten with this testing robot and I cannot find the reason. One reason is - I cannot see successfull checks on qa.d.o. Now debugged down to path module that shows the path field on node forms, but does not save the url alias... I do not understand this as the user have all required permissions and all works fine on my box.