image_attach: image_gallery integration
Squeeself - October 20, 2006 - 17:16
| Project: | Image |
| Version: | 6.x-1.x-dev |
| Component: | image_attach |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
This is a patch we are using on our server for image_attach. It does two things: First, it allows you to attach existing image nodes instead of uploading new images. Second, it provides direct image_gallery integration if image_gallery is enabled. When uploading a new image, you have the option to choose which gallery to assign it to. And, when attaching and existing image, the selection is gallery-aware. Thumbnail previews are shown of all existing images.
| Attachment | Size |
|---|---|
| image_attach.module_0.patch | 7.99 KB |
#1
just FYI - i've committed a modified version to allow attaching existing images. updating this ticket to look at how best to integrate image_gallery.
#2
I use the image_assit module with the image module so I am a bit confused as to what this patch is actually supposed to accomplish when the said functionality already exists
Also how does image_attach work. I downloaded the updated module but dont really know how to use it to attach existing image nodes or atleast I couldnt see anything whiel trying to create a page or an image
Manuj
#3
you may have to enable the attach image in adminster -> settings -> content type, for the content type you want to attach images too.
#4
I already have that enabled, but still dont see any option of how I can attach existing image nodes
#5
This would be useful for me. Makes it much less complex for users to add images to their posts and still have it assigned to a gallery.
However, I just tried applying the patch to the newest version of the image_attach.module and am getting failed patching at Hunks 2 and 3:
Hunk #1 succeeded at 34
Hunk #2 FAILED at 81
Hunk #3 FAILED at 190
Hunk #4 succeeded at 306
I've attached the rejects here.
#6
#7
Patch updated. Conflicts from last patch were because the attach without upload functionality was already in. This patch only includes image_gallery integration.
#8
marked http://drupal.org/node/150936 as a duplicate
#9
A few adjustments were needed for me to get this patch to work with the latest version of image_attach... however it would be really great to see this added to the core of the module.
It really helps keep things organized and categorized.
#10
is there a chance to finish this issue and add it to the core?
is someone working on this issue or have this patch working on his site with Drupal 5.5?
#11
From 2006, for 6.x? Possibly not...
#12
New features go into 6.x-1.x (first and/or only).
#13
i created an other patch to integrate image_attach with image_gallery, basically based on #7 please try and review.
regards
#14
Created a new patch including options for http://drupal.org/node/495522
regards
#15
new version of #14
regards
#16
I got like 3 out of 5 failed patches, so I guess the module has updated a bit since june...
I also tried patching with v1.47, but that messed everything up since the main module probably has changed too much.
Which version of the image module is this last patch referring to?
#17
Probably whichever was latest at the time -- your only guide will be CVS as this is what patches should be against.
If you need this functionality, rather than find an old version to apply the patch to, a better use of your time would be to reroll the patch to the latest CVS head and share it here for other users to review, so I can then commit it!
#18
i created a reroll to fit to the latest 6.1 dev Version.
regards