Posted by hswong3i on September 7, 2010 at 6:40am
2 followers
| Project: | Colorbox |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | hswong3i |
| Status: | closed (won't fix) |
Issue Summary
Hi all,
I am using Lightbox2 for more than 3 years but it looks too buggy even with latest -dev now. Therefore I switch to Colorbox as a replacement for next generation. BTW, when I am using it with image.module + img_assist.module + wysiwyg.module + tinymce, Colorbox have no way to preform automatically handling on-the-fly. It would be a good idea if able to clone such handling from Lightbox2.
Patch attached is a clone based on latest colorbox image.module integration handling. It will only activate when user insert image as:
- admin/settings/img_assist -> Creation of image derivatives -> (enable) Allow users with access advanced options permission to create custom size inline images.
- admin/settings/img_assist -> Creation of image derivatives -> (enable) Allow all users to create custom size inline images.
- Image inserted with "Link to image page" OR "Go to URL" (whatever URL will replace as colorbox)
- Able to load original image unless with permission "view original images" (same as image attach integration)
Patch via colorbox-6.x-1.x-dev, tested with drupal-6.19 + image-6.x-1.0-beta6 + img_assist-6.x-3.x-dev + wysiwyg-6.x-2.1. It is now apply to my blog http://edin.no-ip.com/ as reference.
Regards,
Edison Wong
| Attachment | Size |
|---|---|
| colorbox-6.x-1.x-1283838740.patch | 4.14 KB |
Comments
#1
Looks like a solid patch so I have committed it to 6-dev. If you feel up to it you can port the patch to 7-dev as well.
Thanks for helping make Colorbox the best Lightbox solution!
#2
Wow thanks for your prompt reply and quick commit :D
Here is the patch for colorbox-7.x-1.x-dev. Simply apply above patch to DRUPAL-7--1 and minor update with drupal_add_js() in colorbox.module. Also update colorbox_img_assist_module.js syntax as that of colorbox_image_module.js. It should be logically functioning.
BTW, as there is currently no plan for img_assist-7.x-1.x-dev (http://drupal.org/project/issues/img_assist?order=last_comment_timestamp...) and someone even suggest for Media module as recommended path in Drupal 7.x (http://drupal.org/node/841568#comment-3156728), I would like to suggest keep this colorbox-7.x-1.x-dev patch on hold. Until there is any schedule for img_assist D7 port, let's come back with this issue again.
Moreover, I will study about Media module for D7. So if this looks much powerful than that of img_assist, I may also contribute patch for colorbox and so on ;)
#3
Ok, lets hold it for now.
Would be excellent to get support for the Media module in Colorbox, or support for Colorbox in the Media module. The later is often a cleaner and better solution.
#4
Closing old issues that doesn't seem to affect a lot of users.