Hi,

The module seems to be using the wrong names for xml elements in the merchant part of an ideal request: e.g. merchant_id instead of merchantID.
I included a patch that fixes this, but also adds some other things: a test page next to the config page, a description property, a redirect to the issuerAuthenticationURL instead of a drupal_goto.

CommentFileSizeAuthor
ideal.patch7.95 KBjpulles

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Closed (won't fix)

- The wrong xml elements have been fixed in a series of commits just now. I accidentally committed the wrong patch, which included a fix for that problem as well. Thanks for finding it. Sorry that you didn't get credit in the commit message.
- The test payment should've been removed some time ago already. I just removed the function that was left behind. Acquirers will get their own testing functions in the future.
- AFAIK there is a bug in the payment form so it doesn't show the textfield if a payment amount is set, but this should not be solved by adding a completely new element in an else statement.
- drupal_goto() is Drupal's alternative to setting a location header with header().
- THe patch contains debugging code and lines of old code that are commented out.

To keep things managable, could you please create one issue for one problem and describe what's wrong, how you solved it and why you solved it that particular way? It makes it easier for us to review and commit the code that way. I'll close this issue as an indicator that it should be split up in new, smaller issues, not because we don't want to look at your patch.

Thanks a lot for your time! :)