Users that are set to inactive (blocked) still are sync'd if they retain the appropriate roles. Either blocked users should be removed by default, or there should be a setting.

Comments

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new585 bytes

This is pretty heavy-handed. It could probably be turned into an option in the interface. Let's review this first.

tim.plunkett’s picture

StatusFileSize
new759 bytes

Accounting for arrays.

tim.plunkett’s picture

Bump.

magnus’s picture

Version: 6.x-2.2 » 6.x-2.x-dev
Status: Needs review » Needs work

I recently blocked an user and weren't aware of that his email in Mailman still existed. I applied the patch and changed his account to active again, and then reblocked his account. But his email still exist in Mailman.
I guess I have to delete his email in the users table for now.

magnus’s picture

Priority: Normal » Major
samuelet’s picture

Sorry for late reply but i was quite busy in this period.
First of all, thanks for the patch Tim.
The patch prevents blocked users to change their subscriptions, but it does not disable them if previuosly set, as pointed out by Magnus.
A solution could be to delete the mailman user subscriptions when the user blocking event is fired. If afterwards ublocked, the subscriptions status previous to the blocking event, which is recorded in the drupal table, could be recovered.
The negative consequence is that they will lose their mailman password and any configured extra option not managed by UMR (like the category preferences, etc), which could be a issue if your users manage their subscription also thru the mailman user interface.
Just a note, currently the mailman subscriptions are deleted by UMR when a drupal user is deleted.
Thoughts about this issue?

magnus’s picture

The community I administer have only dealt with blocked users two times in 16 years so this is not a high priority for me. If the user gets unsubscribed and loses all settings it's fine with me. If he gets unblocked, then he could be subscribed again and would have to set his personal settings again. For me the users never do any personal settings and are just happy that they are synced with the Drupal site :)

In the Mailman user interface membership handling there is an option to set a user to "nomail [Reason]". The "reason" would be an "A" - Delivery was disabled by the list administrators.
Could this be used when a user gets blocked? I guess all extra settings are saved then. And, if a user for some reason gets unblocked, then this flag could be unchecked.

samuelet’s picture

I already thought about the nomail way but i rejected it because, according my tests, the user itself can unset the option in his mailman user interface (and probably with an email command too).

magnus’s picture

Weird that the user can change the option even if it is an administrator who set the option, but I verified that the user can change it.

rjlang’s picture

Blocking-->unsubscription (#6) sounds about right. Seems like if someone is being blocked from a site, losing their mailman password and other configurations would be part of the package of being blocked.

Robert

Max2505’s picture

Issue summary: View changes

Is there an option to create a similar patch for the 7.x version?

rjlang’s picture

Status: Needs work » Closed (won't fix)

Sorry, no further changes will happen on versions 5.x and 6.x.

@Max2505 #11, if you'd like to create a patch for version 7.x, please create a new issue and submit it as a patch.