Skins css files not being found

Can you please post the code you are using? Maybe it's a syntax issue? Thanks :)

Thanks :) As long as your CSS file is in /sites/all/skins/blocks/asufusion-blocks.css, I would say this is most likely a valid bug ;)

If you move the Skin back to the theme .info it works I assume...? Will try to test this locally when I get a few minutes.

Hi,
I have the same issue, could very possibly be doing something wrong on my end though.

I can confirm this as a bug.. looking through the function skinr_skin_get_files it seems its only looking for external files in the themes directory.

would placing a copy of the skin directories in the theme itself, temporarily serve as a fix? And would it find it at sites/all/themes/themedir/css/myskinset/ or sites/all/themes/themdir/skins/myskinset/, or would the individual css files have to reside directly in the themes css directory with no myskinset subdirectory.

Sorry if I am making this more confusing than it needs to be, I was just hoping something would work. I would be more than happy to test anything, just let me know what I can do.

@g76, would you mind trying something for me ?

I think the stylesheets are being loaded with the wrong path.

There's a block of code the the _skinr_skinset function that look like this (it should be line 730)

    if (!empty($skinset['options']['inherit_skins'])) {
      // Add paths to $skinr_info.
      _skinr_add_paths_to_files($skinr_info, $path_root);
      // Paths get automatically added to base theme info.
      $base_info  = skinr_inherited_skins($info->name);
      // Merge base theme and current.
      $skinr_info = array_merge($base_info, $skinr_info);
    }

Would someone try commenting the if statement so it looks like this

    //if (!empty($skinset['options']['inherit_skins'])) {
      // Add paths to $skinr_info.
      _skinr_add_paths_to_files($skinr_info, $path_root);
      // Paths get automatically added to base theme info.
      $base_info  = skinr_inherited_skins($info->name);
      // Merge base theme and current.
      $skinr_info = array_merge($base_info, $skinr_info);
    //}

Let me know if this works. I'm not saying this is the solution. I just think the path is never being added to those css/js that are not in the theme directory.

If this fixes your problem I'll look at the code in more detail and come up with an actual patch. (sorry, not in front of a pc right now).

Ok, so I reviewed the code. The problem was the correct path not being added to the css/js. (skinr was just adding the right path to skin that where inherited and it was ignoring every other skin).

This patch should fix this problem.

thank you:),
I was going to do that for you, I just got back in. Let me test that and get back to you. I should be able to do this within the next few hours. Is there anything else I can test as well?

thanks again,
Jen

@g76, You can just test the patch now. It should fix your problem.

Oh you might also want to try moving the skins around. I testing in sites/all/skins and sites/themes/themename/skins. They both seem to work for me.

should I comment out the if statement? I didn't see it in the patch file, but it could very well be me, I am taking multi-tasking to a whole new level today:)

@g76, no need to comment out the if statement. The if statement is still needed for skins that are inherited.

The patch fixes the issue by moving the _skinr_add_paths_to_files function out of the if statement. Which I believe shouldn't be there.

As per #16 it works.

works great, thank you!

Committed :) Thanks!

http://drupal.org/cvs?commit=426986