I started doing some testing with the latest Drupal 7.x-dev builds and I see no icons in any admin page no matter what option is chosen (before/after/replace link) :/

The icons do show up when viewing individual nodes though.

CommentFileSizeAuthor
#7 904948-07-no_icons-d7.patch1.82 KBFreso

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Title: No icons in language switching block except in node pages. » No icons
Category: bug » support

...now using latest D7 dev and latest 7.x-1.x-dev of languageicons (2010-Dec-04). I am not able to see any icons at all. What might I be doing wrong?

<div class="content">
    <ul class="language-switcher-locale-url"><li class="el first active"><a href="/d7test/el" class="language-link active">Ελληνικά</a></li>
<li class="en last"><a href="/d7test/en" class="language-link">English</a></li>
</ul>  </div>

<div class="links"><ul class="links inline"><li class="en first last"><a href="/d7test/en/content/home-page" class="language-link">English</a></li>
</ul></div>
Freso’s picture

Freso commented
Category: support » bug

You are quite likely not doing anything wrong. The current version for 7.x was a quick-ish port for a pre-RC edition of Drupal 7 (which didn't even have fully updated module porting docs at the time). I'm about to upload an updated port and I was already thinking pinging you here when that is done, so stay tuned to let me know how stuff works out. :)

ps. Thanks for testing!

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

Ok, I'll be standing by for the new upload Frederik and I'll report back once I test it. I just saw the available new 2010-Dec-04 dev and thought that there was something ready for testing, so I gave it a go. Besides, I had no reply here since my initial post back in September, so I wasn't aware you were actually 'cooking' something ;)

Freso’s picture

Freso commented

Okay, I haven't committed the code yet, as I still have one wee outstanding issue to look into. But feel free to test the patch at #995446: Update the 7.x porting guided by upgrade.boombatower.com and see if that solves the issue. :)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

I tested #2, but still no magic :(

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

...I mean #1 (it was the second patch in the issue).

Freso’s picture

Freso commented
Title: No icons » No icons are showing
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new 904948-07-no_icons-d7.patch1.82 KB

Alright, I've fiddled around a bit. Check this one out.

I'm currently in a bit of a pinch though, as the node links now get two language icons... but, hey, it's better than none, right? :) Any ideas would be appreciated.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

Did you clear caches and all? I'm saying because in my setup it works as advertised (1 single icon).

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Title: No icons are showing » No icons (or two icons) are showing
Status: Needs review » Reviewed & tested by the community

+ a minor title change to see if others are having your issue as well.

Freso’s picture

Freso commented
Title: No icons (or two icons) are showing » No icons are showing

Let's keep the double icon out of this issue, as it's an issue with the patch, and not with code currently in CVS. :)

Under settings, have you ticked off both node links and language switcher block links?

Freso’s picture

Freso commented
Status: Reviewed & tested by the community » Fixed

Alright, I've committed the patch. I've also created a follow-up issue at #1005144: Doesn't differentiate between node and language switcher blocks.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

Thanx Frederik ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bavarian’s picture

bavarian commented
Title: No icons are showing » No icons are showing - not resolved for me

Issue not resolved, no flag-icons showing unfortunately. using 7.x-1.0-alpha1 (which obviously has the patch mentioned here already applied, right?)

Notice: Undefined index: language i languageicons_link_add() (rad 102 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Trying to get property of non-object i theme_languageicons_icon() (rad 132 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Undefined index: language i languageicons_link_add() (rad 102 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Trying to get property of non-object i theme_languageicons_icon() (rad 132 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Undefined index: language i languageicons_link_add() (rad 102 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Trying to get property of non-object i theme_languageicons_icon() (rad 132 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Undefined index: language i languageicons_link_add() (rad 102 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Trying to get property of non-object i theme_languageicons_icon() (rad 132 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Undefined index: language i languageicons_link_add() (rad 102 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Trying to get property of non-object i theme_languageicons_icon() (rad 132 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Undefined index: language i languageicons_link_add() (rad 102 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.module).
Notice: Trying to get property of non-object i theme_languageicons_icon() (rad 132 av/home/xxxxxxxxx/public_html/yyyyyyy/gtm_0.0_D7.0/sites/all/modules/languageicons/languageicons.modul

Freso’s picture

Freso commented
Title: No icons are showing - not resolved for me » No icons are showing

This issue was fixed and closed, please open a new issue if you experience something similar.