Closed (fixed)
Project:
Amazon Product Advertisement API
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Sep 2010 at 08:36 UTC
Updated:
12 Dec 2010 at 17:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
rfayComment #2
the_g_bomb commentedFirst off not sure if it will make any difference but the we might need to change the version of the API being used:
define('AMAZON_ECS_SCHEMA', '2009-03-31');current version is: Developer Guide (API Version 2010-09-01)
http://docs.amazonwebservices.com/AWSECommerceService/latest/DG/Optional...
Not many changes required to ensure the data doesn't vanish in November as the IFrameURL is being pulled in at present. May need to change the amazon.views.inc file to remove the references to customer data that will not be available.
Ultimately, I think, we will need to grab and process the iframe page to extract the necessary customer review data, so that it can be saved to the database as it is currently.
Comment #3
rfayNice work on this. I don't think the schema ever ends up mattering, but it's fine to update it.
Comment #4
the_g_bomb commentedI just installed a fresh version of drupal and amazon (only) to trace the code and ensure I understood everything going on before attempting to resolve this.
The weird thing I discovered was that the iframeURL does not get pulled in if you use the test function or just look up the item. After you run cron, though the iframeURL gets pulled in.
Comment #5
the_g_bomb commentedMy bad, it isn't to do with cron. It was a clear cache and I had updated the AMAZON_ECS_SCHEMA, but it didn't take effect until I ran cron.
You do need the updated API VERSION to get the iFrameURL
Comment #6
the_g_bomb commentedAlthough the test still isn't showing up the iframeURL, which is due to the amazon_item_clean_xml
Perhaps if we actually passed some more values into the items array:
// from line 515 of amazon.module
Comment #7
rfayComment #8
rfayThanks for blazing the trail on this, @the_g_bomb!
Here's the additional work I think needs to be done. Since they will no longer be providing any customer review data, we can drop the table, remove that stuff from the view, etc.
Could you test the upgrade path (and the fresh install path) and comment as needed?
Thanks,
-Randy
Comment #9
the_g_bomb commentedI'm struggling to get this patch fully applied other than manually and even then I am not 100% confident I have everything. The automatic patching I am trying seems to have an issue with:
CHANGELOG.txt
amazon.admin.inc
amazon.install
I am trying to upgrade from amazon (6.x-1.1).
The one thing that concerned me was that there doesn't seem to be an function amazon_update_6014() in anyof the versions I checkout, althought it is referenced in the patch file. Would prefer to get the patch properly applied before I actually test the module itself.
That being said, eyeballing the code, and from the couple of sweeps of the patch I have made, the code changes look ok to me.
Comment #10
rfay@the_g_bomb, patches are (almost) always against the tip, which in this case is DRUPAL-6--1, which is the same as the dev tarball most of the time. Please give that a try.
Comment #11
the_g_bomb commentedWierd, using DRUPAL-6--1 only amazon.install and amazon.admin.inc gets updated
Comment #12
rfayWell, in that case something is wrong with your process; the patch has changes for amazon.module. You can just look inside it and see that.
Comment #13
rfay@the_g_bomb, I'm in IRC if you want to find me there for any help.
Comment #14
rfayHere's #8 again rerolled against DRUPAL-6--1. Some other commits had in fact made it not apply.
Would appreciate your look-see at this, @the_g_bomb. Just realized that the Amazon deadline is almost here.
Comment #15
rfay#14 committed to DRUPAL-6--1.
Comment #16
rfayNow this has to be done on D7.
Comment #17
rfayHere's the D7 version.
Comment #18
rfayCommitted to HEAD: http://drupal.org/cvs?commit=456522
Will very much appreciate D7 testers taking a look at these.