A line height issue

cog.rusty - October 21, 2006 - 18:28
Project:Chessboard Renderer
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

While trying the chessboard with Andreas09 theme, I found that the images of the squares had borders and paddings. This was due to a "#content img" tag which has already been removed from Andreas09 in the head version because of probems with TinyMCE (http://drupal.org/node/67472). So far so good.

However, even after removing that, the line spacing was wrong. I found that it can be corrected by adding

line-height: 1em

in chessboard.css, in div.chessboard. I think this is useful for all themes which change the line height and I can't think of any undesirable side effects.

#1

cog.rusty - November 16, 2006 - 17:48

Here's an example link with my CSS suggestions. Not sure how long it will stay there -- probably a few weeks.

http://dru47.cogville.com/taxonomy/term/10

#2

vyvee - November 17, 2006 - 08:45
Status:active» needs work

Dear CogRusty,

So glad to get your suggestion! I have been extremely busy these weeks to update the code... but I've tested it once locally with the corrected CSS. I'll update the code soon. As you can see... I use 'font-size: 0;' at the moment but I also found it's not always effective. So thanks for the answer! :)

I hope I can extend/rewrite it to make the module to be able to play a PGN game...

#3

cog.rusty - November 21, 2006 - 13:58

Hi vyvee

I noticed that I had taxonomy access control enabed on that test site, not sure at what point. So, I am not sure if you ever saw my example. The link works now.

#4

vyvee - November 22, 2006 - 02:15

I indeed failed to see your example a few days ago, but just saw it just now. Wow! It's great! Saw the chess diagrams from other programs too.

#5

cog.rusty - November 22, 2006 - 02:37

If you install Andreas01 (some other themes also have this problem) you will see how the new lines in .chessboard img fix one problem and the new line in div.chessboard fix a second problem.

 
 

Drupal is a registered trademark of Dries Buytaert.