Posted by adrianmak on September 8, 2010 at 1:51pm
3 followers
Jump to:
| Project: | Quick Tabs |
| Version: | 6.x-2.0-rc4 |
| Component: | Miscellaneous |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
could I put under my own theme folder ?
Comments
#1
even though I created another tabstyles folder under the module, quicktabs cannot recognize the new tabstyle
#2
you need a css file also..
the new tabstyle should go into the theme, but it does not work..
only solution for now is to put it into QT module tabstyles directory, or implement the hook_quicktabs_tabstyles() in a custom module..
#3
As a guy who has to manage 25 multisites in an Enterprise environment with source code control, can I just say for the record that this is a BIG problem?
You've got theming stuff in sites/all/modules/quicktabs which I need to wholesale replace to be certain that all suspect code from a security vulnerability is gone, but I can't, because that's going to nuke the theming of the quicktabs and...
Put it in the DB, or put it in sites/example.com/themes/quicktab/ or something, but NOT mingled in with your module code.
I'm not bumping this up to major as that would be rude, but it's sure a major problem to me.
#4
@RichardLynch:
if you do not want to create a module, then you can still use the basic style and override it in the theme as you like..
for the D7 version the hook should be an alter hook then themes could add additional styles.. I do not see a solution how a theme could add additional styles in D6. Do you have examples of other D6 modules which allow similar thing?
#5
It makes perfect sense, but...
I'm not the guy who creates the theme/css etc.
I'm just the guy who has to apply Security Patches, and can't.
We can have a corporate policy of "don't do that" but you can guess how well that pans out with a revolving door of consultants creating Drupal themes for a lot of sites...
My point is that it's just bad architecture to put theming into the code.
Drupal is a semi-MVC type architecture, and this violates that separation of code and presentation.