CVS edit link for bischoff.alex

I have created a module to correctly calculate sales tax for Ubercart

The module is implemented using hook_menu, hook_calculate_tax and hook_order

The determination of sales tax rates is provided by a commercial company called AvaTax who are generously offering a free license for a limited number of transactions and their basic look up service.

The calls to their SOAP API they support require downloading a copy of their PHP SDK and including a license key. The SDK includes a ssl certificate for encryption of the communication to their service. I understand that providing this download may NOT be included here. I have tested the process of copying the library, and library key, as a sub-directory of the module - working fine.

I plan for 3 additional modules, each offering increased functionality, up to a 100% outsourced calculate, report, and pay sales tax monies - with AvaTax assuming liability for any sales tax penalties.

The administration page provides for various options on how to determine sales Nexus and tax rates.

The module is particularly required for California where counties have local taxes, that require actual address validation to determine inclusion in tax jurisdictions if the correct local rates are to be applied

CommentFileSizeAuthor
#1 uc_tax_avatax_calc.zip4.88 KBadTumbler

Comments

adTumbler’s picture

adTumbler commented
Component: miscellaneous » Miscellaneous
Status: Closed (won't fix) » Needs review
Issue tags: -Ubercart, -Module review
StatusFileSize
new uc_tax_avatax_calc.zip4.88 KB

Please note that I have changed my user name to adTumbler & email to bischoff.alex@adtumbler.com

I was using a personal email, but part of asking for this account and publishing this module if changing my role from a part time owner of the web site open4energy.com to a business that can support Drupal - especially Ubercart

I hope you can issue the CVS account using the updated information.

I have attached a zip of the latest beta of the module and the info (which I modified by hand)

I have not uploaded a copy of the PHP Class libraries referenced - they are not open source.

NB - May I correct the posting above - Avalara DO NOT assume tax liability - they do offer a service called AvaFile where they offer service level agreements for disbursing sales tax monies.

NB - Please do NOT use the attached file - it is more than a year out of date - please contact me at http://drupalsalestax.com if you would like a trial AvaTax account and a copy of the module!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: bischoff.alex [bischoffalex] » adTumbler [adTumbler]
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Ubercart, +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

tr’s picture

tr commented

Please install the Coder module and use it to bring your contribution into compliance with Drupal coding standards.

You should use hook_requirements() to check whether SOAP is available - it's not included with PHP by default.

A README.txt describing installation and configuration would be very useful. This should include links to download the necessary third-party libraries as well as instructions for where to put those libraries.

I suggest if all your "3 additional modules" will be using the AvaTax service, they should really all be combined into one module so they can share common code. Breaking this one big module into conditionally-loaded .inc files will allow users to enable and load only the portion they need.

I haven't tested the code, but it does fill a need and doesn't duplicate any other module so I think the application should be approved.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

I am changing the status as per previous comment.

adTumbler’s picture

adTumbler commented

Reviewers

Many thanks for your helpful suggestions.

I will move ahead with the next phase of work - error handling, documentation and further testing

I will think through the best way to handle the different levels of integration with Avalar - using includes or requiring different modules - and provide a technical explanation for the approach taken.

I will let you know when this is ready for review

Alex

jlevy’s picture

jlevy commented

Alex,

Are you still planning on developing a full featured Avatax module for Ubercart (including posting and committing)? I have been thinking about developing that module, but since I happened to see this post, I thought I would check with you first. I don't want to duplicate effort.

Please let me know if you are still actively working on this.

Thanks,
Jeff

zzolo’s picture

zzolo commented
Component: Miscellaneous » miscellaneous
Status: Needs work » Closed (won't fix)

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
adTumbler’s picture

adTumbler commented

Hi Jeff

Yes, the module is completed - save testing and documentation

I am in final stages of negotiation with Avalara to make their library available to the Drupal community - a free testing account - and charges to end user web sites only.

A similar model to the one PayPal use

Alex

PS - It is going to need some help - please let me know how I can reach you to discuss

jerry’s picture

jerry commented

I'd like to see this move ahead as well. Let me know if you need an additional hand in reviewing and/or testing the module.

adTumbler’s picture

adTumbler commented

Jerry

I do apologize, I missed your reply

The module is now at version 1.4 - and is in production on a number of sites.

I am not able to post the module as it requires a commercial library supplied by Avalara, and an account on their AvaTax calc service.

If anyone needs a trial AvaTax account, and a copy of the module - best way is to go to the web site:

Open4BioClean

Use the Contact us form - it will get to me!

Status: Needs review » Closed (won't fix)

Correcting issue status, see #2125263: Issue status not taken from last comment during D7 migration.

tr’s picture

tr commented
Component: Miscellaneous » new project application
Issue summary: View changes

Hiding the attachment in the summary, because as per comment #1 it should not be used.

adTumbler’s picture

adTumbler commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Please read the following links as this is very important information about CVS applications.