Incompatible with Menu Attributes module

have the same problem
Nice Menus 6.x-2.1
Menu Attributes 6.x-2.0-beta1

I have the same problem...

Hello

I have the same problem with the 7.x-2.0-beta2 version. I want the menu_attribute class on the "li" and not on the "a" tag, so I did the following (in nice_menu.module, around line 447):

<?php
if ($trail && in_array($mlid, $trail)) {
  $class .= ' active-trail';
}
// -- Begin change
if (isset($menu_item['link']['options']['attributes']['class'])) {
  $class .= ' ' . $menu_item['link']['options']['attributes']['class'];
}
// -- End change
// If it has children build a nice little tree under it.
?>

You can also do something like this (starting in nice_menus.module line 450) (look for the capital case comments :)):

<?php
      // --> ADDED THIS
      if (isset($menu_item['link']['options'])) {
        $options = $menu_item['link']['options'];
      }
      // --> END

      // If it has children build a nice little tree under it.
      if ((!empty($menu_item['link']['has_children'])) && (!empty($menu_item['below'])) && $depth != 0) {
        // Keep passing children into the function 'til we get them all.
        $children = theme('nice_menus_build', array('menu' => $menu_item['below'], 'depth' => $depth, 'trail' => $trail));
        // Set the class to parent only of children are displayed.
        $parent_class = ($children && ($menu_item['link']['depth'] <= $depth || $depth == -1)) ? 'menuparent ' : '';
         
         $element = array(
          '#below' => '',
          '#title' => $menu_item['link']['link_title'],
          '#href' =>  $menu_item['link']['href'],
          '#localized_options' => $options, // --> CHANGED THIS
          '#attributes' => array(),
        );
        $variables['element'] = $element;
        
        $output .= '<li class="menu-' . $mlid . ' ' . $parent_class . $class . $first_class . $oddeven_class . $last_class . '">'. theme('nice_menus_menu_item_link', $variables);
        // Check our depth parameters.
        if ($menu_item['link']['depth'] <= $depth || $depth == -1) {
          // Build the child UL only if children are displayed for the user.
          if ($children) {
            $output .= '<ul>';
            $output .= $children;
            $output .= "</ul>\n";
          }
        }
        $output .= "</li>\n";
      }
      else {
     
        $element = array(
          '#below' => '',
          '#title' => $menu_item['link']['link_title'],
          '#href' =>  $menu_item['link']['href'],
          '#localized_options' => $options,  // --> CHANGED THIS
          '#attributes' => array(),
        );
        $variables['element'] = $element;
        $output .= '<li class="menu-' . $mlid . ' ' . $class . $first_class . $oddeven_class . $last_class . '">' . theme('nice_menus_menu_item_link', $variables) . "</li>\n";
      }
?>

This will put the class on the "a" instead of the "li".

Maybe this is not the way to do it, but it helped me out for now :)

Oz

** See #6 **
This one liner patch fixes the D7 version incompatibility with menu_attributes module (for me). Any classes that I set are now applied to the links.

On a quick look this patch is working for me.

tnx

The patch in #4 missed one spot. Here's a revised version.

The patch at #6 is exactly what I needed to get special_menu_items and my own stack altering modules working.

Thanks!

Re-rolled as a proper git patch, with credit to @jtwalters and @joelstein.

Still RTBC.

Re-rolled the patch again from #9 with --no-prefix.

drush_make didn't like the format of the patch from #9. This patch will work with drush_make.

worked for me. thanks!

committed with 624d25cc7f01f

um...

Did the D6 version ever get a patch?

I'm looking for a Drupal 6 solution too - anyone fix it???

q./