Context Metatags

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

• The points reported in this review are not in order of importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. The version line needs to be removed from the .info file.
2. The package name is used only when it's the same name used for other modules.
3. The code of the module doesn't seem complete. The requirements ask for a complete module.

4. /**
    * Returns the rendered metatags for actibe context.
    */
   
   

   Actibe?

5.     if (preg_match('/HTTP\/1.1 404 Not Found|HTTP\/1.1 403 Forbidden/', $headers)) {
         return; // Do nothing.
       }
   
   

   Why isn't the code checking for the same headers used by HTTP 1.0?
   Why isn't the code considering any custom headers Apache could return?

6.       else {
           drupal_set_html_head('<meta name="' . $key . '" content="' . $value . '" />');
         }
   
   

   HTML tags content should be passed through specific Drupal functions, before to be output.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

Updating Issue Title

Updating issue priority, as per the new application priority guidelines.

Excellent module for SEO purposes. Using it on one site already.

It seems like another project has been published recently which seems to have the same scope:
http://drupal.org/project/context_metadata

I did not test the other one yet so I can not tell if it is equally good / better / not as good as context_metatags.

I vote in favour of gdud's context_metatags.
It is indeed lightweight and integrates nicely with context.

And I can confirm that context_metatags is stable enough to use in production.

Context_metadata is good, but only if you want to use nodewords and pagetitle with all its complexities.

Did a very quick initial screening ... didn't come across any glaring issues.

Looks like all printible output is sanitized and strings are translated (with proper variable substitution) ... though to be sure, I would still wrap $key in a check_plain() on line 160 of context_metatags.module.

Remove the $ID tags ... this is a CVS artifact left over from before Drupal migrated to Git, and they are no longer required (despite the Coder module saying otherwise until recently!)

Items flagged by kiamlaluno in #5 have been addressed, though I suspect there may be certain situations where the 403/404 header match could break ... it may be worth simply matching on the result code, as the text returned with them could be different across various technologies.

Project page description could use some some small wording tweaks and spelling fixes (though I realize that English may not be your first language).

None of the above should really be show-stoppers ... so assuming you'll address them before promoting the project, and given the community comments suggesting that everything works (as I didn't perform a run test and haven't used Context), I'll mark this one RTBC.