Support the Features module API to allow bundling of CKEditor's visibility settings

Same here, but I can't save any settings for CKEditor on my features.

If none of CKEditor maintainers started working on this issue, I'll take a look on it.

neilnz's patch from #968416: Support for exporting CKEditor profiles into features (Features module integration) - patch. I've changed this patch a little (remove the unknown "rank" variable, fix the path).

Patch applied cleanly to my 1.2 install, and I managed to successfully export all profiles. Will be able to test the import on another machine tomorrow

Successfully imported the feature to another box, no hiccups. I am happy with this patch. I do not know if more eyes are required over it though. Would be keen to see this patch in the next release!

Going to try this as well.

Applied and worked fine, although I got a couple foreach() errors on it. These did not seem to affect the revert feature though.

So I second the RTBC. Let's get it in -dev!

Everything seems to be working. However, I also get a warning:

Invalid argument supplied for foreach() in /var/www/cms/modules/ckeditor/includes/ckeditor.features.inc on line 69.

And another:

array_values(): The argument should be an array in /var/www/cms/modules/ckeditor/includes/ckeditor.features.inc on line 44.

Tested the patch, but for me it didn't work. Not getting errors, just no exported profiles.

I did get the option to add CKEditor profiles to my feature but my exported values were not respected on install. The CKEditor profile sport an 'overridden' status, probably because my exported variables are reset by the installation sequence of the CKEditor module itself.

I make some changes in patch and commit it to CVS. Everything seems to work.

Please check the latest dev release and let me know if you notice any poblems with it. Remember to clear Drupal cache and browsers cache before testing.

@jcisio, really thx for your patch and good job :)

Greetings

dczepierga, no I won't take the credit, as I stated in #5 that it was not my patch, but neilnz's, I just did some small modification.

Ahhh sry my fault...
@neilnz, so really thx for good work and u @jcisio for modifications :)

Greetings

I've updated the provided patch to resolve the warning issue. The section of code causing the warning actually does nothing (roles are not stored in settings) so I removed it. All functionality now works as expected.

This is a high priority feature for me so please commit this. I'm not sure why the issue is marked fixed because there is no indication it has been committed so I'm changing the status.

It was committed at http://drupal.org/cvs?commit=500476 but only in 6.x.

Works for me. Setting this as fixed.

Now I'm confused.

It's still not working for me. I'm working with my own installation profile.

I upgraded to latest .dev release, since it was committed. I then noticed my CKeditor profile settings appeared as 'overridden' still in my features admin interface and indeed my exported variables were ignored on the ckeditor settings page.

I then tried the patch and got

patching file ckeditor.module
Hunk #1 succeeded at 1175 with fuzz 2 (offset 49 lines).
The next patch would create the file includes/ckeditor.features.inc,
which already exists! Assume -R? [n] y
patching file includes/ckeditor.features.inc
patch: **** unexpected end of file in patch

I ran my install profile again, which failed and gave me a critical error concerning ckeditor. Only when I revert I get the changes to propagate.

What am I missing?

Maybe try to use last DEV version of CKEditor module, there any patch is not needed to work with it...

Greetings

@dczepierga,

Thanks, but indeed I tried that at first, without applying a patch. But it doesn't work... Any thoughts?

Tentatively setting this back to 'needs work', for the committed patch does work on activating a feature manually, but after my extensive efforts to get this to work in an installation profile I can report that automated install fails.

My steps / info:

- My install profile enables/ installs a few features, the first one includes the new ckeditor dev version and an export of general, default and advanced profile. It also includes IMCE, which is set as the default filebrowser in the export.

- My install profile reverts all features at the end

- In my .profile file, I have tried enabling both ckeditor and imce before the features are enabled but to no avail.

- The feature containing the ckeditor export appears as overridden after install and only when I revert it manually the ckeditor profile settings are propagated.

Hope this helps and my thanks in advance for any guidance on this.

@AlfTheCat, i move your bug report to new issue - #1103980: Features module - automated install fails.

I closed this issue, because we give support for this module and release new version with it, so all bugs should be reported apart.

Greetings

Hi dczepierga, thanks and grateful for your continued help on this!