Missing argument 2 for pay::form()

Hi Mikl,

I haven't seen this error myself yet, can you provide any further information on the configuration you're working with? What payment method are you using and how is it configured? How is your donation form configured? Screenshots may also be helpful.

Thanks!

Jeremiah

I can confirm what's happening. I'm not sure how mikl is triggering it because I haven't seen it either, but the lines he is citing, ~122, illustrate what's going on.

When I first wrote pay, the form() method was returning a form, kinda like how a CCK widget, webform component, hook_user, etc. might work. But that was inflexible because your form handler might want to use an email/amount/etc. field from elsewhere in the form. Thus, I rewrote things so that pay::form() gets $form and $form_state by reference, and does not return anything.

pay_form::form() extends pay::form(). These methods are both operating by reference and everything works out great. However, the code mikl is pointing to expects pay_method::form() to function the "old way", and however he is using it is breaking things.

Since this is working "properly" elsewhere, a workaround is to do what other handlers are doing to avoid running into this. However the correct solution is to fix pay_method so that it behaves consistently by using referenced values of $form and $form_state.

This seems tricky because we're expecting to embed multiple, possibly-conflicting pay_method formlets. But it's entirely possible I'm overthinking things. In fact, it might be nice if the payment methods wound up sharing certain details, such as billing address, but maintained their own fields for specific backend details.

I tried PayPal with Webform Pay and I got this error.

I ended up with this.

Hello all, first off, great idea for the module, I am however unfortunately receiving this same error. I am currently trying to implement this in conjunction with the Webform Pay module using the Credit Card payment type. If I switch to Authorize.net I do not receive this error. The modules involved with this are all updated to the correct versions. I attempted to apply the patch provided by sgabe, I added the three new lines to the pay_method_direct.inc file so it now reads:

class pay_method_direct extends pay_method {
// added the following three lines in a patch attempt
function form() {
parent::form($form, $form_state);
}
function settings_form(&$form, &$form_state) {
parent::settings_form($form, $form_state);
$group = $this->handler();

// Eliminate the 'authorized' option from the settings.
unset($form[$group]['pay_form_activity']['#options']['authorize']);
}
}

With these changes and all caches flushed I am still receiving the same error for the Credit Card payment type. Is there any other information you guys may need from me to help get this issue resolved? Thanks in advance.

Note that I used Webform Pay with a custom payment method which extends the pay_method_direct class. I don't know Credit Card payment type, is that a direct method? I don't think so... Could you provide a link to it's project page?

I added the Credit Card payment method within the Payment Configuration section, the correct title would have been "Custom Payment" but I renamed it to credit card, apologies for the confusion. It, along with Authorize.net where the two types of payments available when I installed the module. Authorize.net was available because I also installed the authorize.net payment(http://drupal.org/project/authorizenet). In the payment settings area it says the handler is a custom payment, that should be used for "Manual payment entry, for COD payments, pledges, or manually incrementing a total." which is what I was hoping to accomplish using this module. I am thinking now this means I am supposed to write a custom payment method, such as you say you have done. I guess I had assumed it was an option built into the Pay module.

Thanks for the quick response. I really appreciate it.

I just committed a change. If people could have a look and make sure the error has gone away where they were seeing it, I'd really appreciate that!

IMPORTANT - see http://drupal.org/cvs?commit=455452 for details on possible API breakage if you're working on a pay_method module that implements form() for some reason.

Error Persists - Clean installation of a6.

NM, Just one of those days.

I can confirm this as a fix. However Webform Pay needs to be updated.

I'm using Pay 6.x-1.0 and Donate 6.x-1.0-alpha2 on a Drupal 6.20 installation.

I'm seeing a similar error as above:

warning: Missing argument 2 for pay_form::pay_method_form(), called in [redacted]/sites/all/modules/donate/includes/donate.inc on line 199 and defined in [redacted]/sites/all/modules/pay/includes/handlers/pay_form.inc on line 146.

I'm using a Sandbox PayPal Payments integration.

There is a thread with more details in the Donate module's issue queue:
http://drupal.org/node/1092328

Issue still persists.

See also #1130298: Missing argument 2