Posted by frjo on October 23, 2006 at 6:35am
| Project: | Content Recommendation Engine |
| Version: | master |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I use this module on my site vigillar.se together with my Vote up/down module and I really like it!
I wanted to contribute in some way so I made the code follow the Drupal coding standard a little closer. There should be no change in how the module function, at least I hope so. I have looked at things like:
* Two spaces in place of one tab
* Always a space after a colon
* valid xhtml <br /> not <br>
* Avoid using "..." if not necessary, use '...' instead
* Only use uppercase at start of sentence/string
* Made all comments in the following style
/**
* Comment here.
*/
Comments
#1
And the patch that I missed to add to the first post.
#2
Outstanding! Thank you for this. I know you mention this earlier and I managed to forget about out. Thank you for taking the time to clean up my work. Its pretty now.
#3
Just a reminder to make sure you noticed that the file above includes patches for all the module files.
cre:
cre.module_clean_01.patch
recommendation_modules:
comment_recommendation.module_clean_01.patch
node_recommendation.module_clean_01.patch
user_recommendation.module_clean_01.patch
I also think it would be best to rename "Recommendation Modules" to something like "recommendation_modules" without spaces and uppercase.
#4