Reviewed & tested by the community
Project:
Antonelli
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Sep 2010 at 14:57 UTC
Updated:
12 Sep 2010 at 10:03 UTC
Great that this is here now!
When looking through the first thing I see is the primary link tabs are messed up. They are messed up because the styles for #secondary-menu are missing in layout.css. By including css/layout.css in antonelli.info you are also excluding Bartik's core layout.css. If that was the plan to override Bartik's styles then we should add this code to Antonelli's layout.css:
#secondary-menu {
position: absolute;
right: 0;
top: 0;
width: 480px;
}
Otherwise renaming layout.css to something else would work too, I'm just not sure if this is part of how you wanted Bartik overridden.
Comments
Comment #1
BenK commentedTracking this...
Comment #2
Jeff Burnz commentedYep, its a total override, there's no point in loading both - the new secondary menu position has to be added since that was recently committed - #889982: Move secondary links to the header in Bartik thanks for reminding me about this :)
Theres going to be more like this also, in particular the header layout (when or if it ever gets fixed...) - #845834: Fix Bartiks Header because its totally borked
Could be others also, there's a number of outstanding issues with patches for review that could impact on layout.
Comment #3
Jeff Burnz commentedCommitted a fix http://drupal.org/cvs?commit=419984
Setting as needs review, it should be OK, I should have made a patch first, sorry, I just committed it without thinking - its 50% width instead of the 480px from the fixed width version.
Comment #4
aschiwi commentedThis looks fixed now. I wonder if this way makes it hard to maintain the theme? I wonder if it would be better to just override some parts?
Comment #5
Jeff Burnz commentedI think it makes it easier to maintain and is more performant (why load two stylesheets when we only really need one) - almost everything is overridden in one way or another so we'd just be duplicating everything. Its just a matter of chasing HEAD until D7 release, which shouldn't be that many changes from now on (although I may need reminding - I'm pretty busy with work and other D7 patches).