hey

the standard directory nowadays for external libraries/scripts is /sites/all/libraries

could you change the way the module behaves so it searches jQuery Colorpicker there instead?
also, the standard directory names for jquery plugins are something like "jquery.pluginname"

for jquery colorpicker it could be jquery.colorpicker:
/sites/all/libraries/jquery.colorpicker/js/colorpicker.js

CommentFileSizeAuthor
#7 libraries_support-909086-7.patch3.54 KBdeciphered

Comments

lpalgarvio’s picture

lpalgarvio commented

additionally, you could support loading it through Libraries API.

jaypan’s picture

jaypan
Location Victoria, BC
commented

Sorry for my slow response. I didn't see this post until now - I must have forgotten to turn on notifications for this module.

The Libraries API module is still in alpha, so I won't be adding a dependency on it. I will only add dependencies to modules that don't have a full release if there is no other option - which in this case there is.

I'll look at moving the library to the libraries folder however. Give me a week or two - I'm right in the middle of a few projects and I'll need to do a bit of research to see how others are referencing the libraries folder. I'll also have to put in a backup conditional for people who are upgrading but haven't moved their library to the libraries folder.

cyberwolf’s picture

cyberwolf commented

hook_library is in core now (D7) ;)

jaypan’s picture

jaypan
Location Victoria, BC
commented

In that case, I will probably move the D7 version to the libraries folder in my next release. I'll try to get that out within the next two weeks. Moving D6 isn't my biggest priority at the moment however, and will probably take me longer to do it.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

+1 for this, without Libraries support it makes it very difficult for people creating Drush makefiles or install profiles.

Will likely take a quick look at the module this afternoon and if it meets my needs I will take a look at writing a patch for Libraries API support.

Cheers,
Deciphered.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Version: 6.x-1.x-dev » 7.x-1.0-beta2
Status: Active » Needs review

Patch for D7 attached, adds support for Libraries API if Libraries API module is present.

A quick note, this module is desperate need of a Coding Standards cleanup, took all of my willpower to not over complicate this patch with a cleanup.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new libraries_support-909086-7.patch3.54 KB

Oops, forgot to attach the patch.

jaypan’s picture

jaypan
Location Victoria, BC
commented
Assigned: Unassigned » plopesc
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Thank you Deciphered!

I will test your patch this afternoon and if it works fine, I will commit it to the repository.

Best Regards

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Closed (fixed)

Hello

Thank you very much for your help.

I tested your patch and committed your changes with minimal corrections related to the $path variable.

I know that the module needs work, but at the moment I can't do it. I hope that this summer we will be able to rewrite it according to Drupal coding standards.

Regards

jaypan’s picture

jaypan
Location Victoria, BC
commented

Myself as well. My partner and I have nine projects on the go at the moment, with some downtime expected in August. I'll be spending a bunch of time on the module at that point.

ericaordinary’s picture

ericaordinary commented

Any chance you could create a dev version of the module and commit this patch to it? It will be very helpful for making install profiles that include the module (which is an excellent module btw!).