If you are using Private file system B7M is denying access to uploaded files in a cck filefield.
backup_migrate_file_download() is denying access to files it has nothing to do with.
Regards
Geoff
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 909872-do-not-deny-access-to-Filefield-files-D6.patch | 869 bytes | mholloway |
Comments
Comment #1
phayes commentedThis is seriously critical as it will break sites that rely on fielfields and private file systems (not a rare occurrence)
Comment #2
eric at nrd commentedsubscribing
This issue appears to disallow access to any filefield data on sites utilizing private files.
It looks to me like _backup_migrate_path_is_in_save_dir($path) is returning a non-null value for all filefield $path inputs. This in turn makes the inner block of backup_migrate_file_download($path) always execute, and thus return -1 for filefield files.
Comment #3
mholloway commentedThis also interferes with modules implementing hook_file_download() for mixed public/private files.
The problem is when _backup_migrate_path_is_in_save_dir() gets an unexpected empty $mode. It should return FALSE in that case.
This patch fixes that problem. Not tested with Filefields problem, but cures my public/private downloads problem.
Comment #4
ronan commentedCan you guys confirm that you're using the latest version in the 2.x branch?
Comment #5
mholloway commentedYes, my public/private files problem was a problem in the 1.x branch and I'm not seeing it in the 2.x branch.
Comment #6
ronan commentedThe 1.x branch is not actively supported, so if you need to use the private file system please make sure you're using the 2.x branch.