Closed (duplicate)
Project:
Drupal core
Version:
6.19
Component:
menu.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Sep 2010 at 14:39 UTC
Updated:
14 Sep 2010 at 12:48 UTC
How to reproduce:
How to resolve:
The quickest way to resolve this issue is to modify the menu.admin.inc file in the menu_edit_item_validate function on line 333. Please see below for the updated code.
/**
* Validate form values for a menu link being added or edited.
*/
function menu_edit_item_validate($form, &$form_state) {
$item = &$form_state['values']['menu'];
$normal_path = drupal_get_normal_path($item['link_path']);
if ($item['link_path'] != $normal_path) {
drupal_set_message(t('The menu system stores system paths only, but will use the URL alias for display. %link_path has been stored as %normal_path', array('%link_path' => $item['link_path'], '%normal_path' => $normal_path)));
$item['link_path'] = $normal_path;
}
if (!menu_path_is_external($item['link_path'])) {
$parsed_link = parse_url($item['link_path']);
// Unset the query parameter in case the user has not applied one in the new form.
unset($item['options']['query']);
if (isset($parsed_link['query'])) {
$item['options']['query'] = $parsed_link['query'];
}
// Unset the fragment parameter in case the user has not applied one in the new form.
unset($item['options']['fragment']);
if (isset($parsed_link['fragment'])) {
$item['options']['fragment'] = $parsed_link['fragment'];
}
if ($item['link_path'] != $parsed_link['path']) {
$item['link_path'] = $parsed_link['path'];
}
}
if (!trim($item['link_path']) || !menu_valid_path($item)) {
form_set_error('link_path', t("The path '@link_path' is either invalid or you do not have access to it.", array('@link_path' => $item['link_path'])));
}
}
Summary:
The above code simply unsets the query and fragment parameters of the options array so that the user has the ability to remove or add this functionality. The parse_url PHP function call handles identifying whether or not that property needs to be saved and will save it to the $items array regardless, so unsetting the query and fragment parameters is safe.
Comments
Comment #1
dddave commentedA patch increases the chances of inclusion dramatically. ;)
http://drupal.org/patch/create
Comment #2
reglogge commentedI cannot reproduce this behavior. The issue seems to have been fixed here #682784: Once created, menu item query strings can never be deleted. Setting this issue to duplicate.
Please check if you are really running Drupal 6.19.