User email/account not linked to signup - missing dependency on uc_payment

I've solved my other problem from (http://drupal.org/node/910140) with the steps below, but this is still not working . . I just wanted to give you feedback on what I did and the results which hopefully will help you a bit:

1. disabled then uninstalled then deleted uc_signup, disabled payment module
2. downloaded and installed uc_signup dev (updated today), reactivated all modules at the same time (i.e. not by dependency)
3. attempted signup as anonymous user - fail - sent me back to fill out profile fields
4. disabled profile fields to be required for registration, also uninstalled content profile & account profile (solved problem above)
5. cleared cart, attempted to signup for an event as anonymous user - success -account created, account details sent
6. log in as new user using emailed credentials - success
7. check for signup as new user - fail - signups tab on profile page said no signups for this user
8. check for signup from admin view on event node - fail, did see anonymous user registration with placeholder information

also, in UC conditional actions, i notice that the condition is now 'check the order balance' to be less than or equal to zero . . . and the action is 'mark temporary signups as paid' . . .

Did some more testing this morning

despite other problems, the beta3 of uc_signup successfully registered users upon signup (different server, relatively clean install). This means that going to the event page and viewing signups showed users with their username and correct emails and did not show user as 'anonymous' and the email as 'placeholder...'. This was accomplished as a registered user signing up two people for an event.

In looking at and testing the code of uc_signup.module of the dev and beta3 (a version hat i remembered successfully registered users) I noted three things:

1.
in dev, the uc_signup_ca_predicate is based on the #trigger 'uc_payment_entered'

in beta3, the uc_signup_ca_predicate is based on the #trigger 'uc_checkout_complete'

2.
in dev, starting on line 476 it reads:
'#conditions' => array(
'#operator' => 'AND',
'#conditions' => array(
array(
'#name' => 'uc_payment_condition_order_balance',

in beta3 staring on line 404 it reads:
'#conditions' => array(
'#operator' => 'AND',
'#name' => 'uc_payment_condition_order_balance',

perhaps in dev the presence of line 478 adn 479 throw things off.

3.
in dev on line 499 it reads:
'order' => 'order',
),

in beta3 on line 423 it reads:
'#settings' => array(
'order_status' => 'payment_received',

I think both the duplicate conditions (2) and the lack of the new setting (3) are the major parts,

**edit** i understand (2) now I think**edit**

I think i understand why you changed the trigger from 'checkout_complete' to 'payment_received' perhaps due to ipn issues with paypal or payment is received but something goes wrong in the next checkout step.

testing report #2

With the test server:
1. I upgraded from beta3 to the dev
2. added 'order_status' => 'payment_received', to line 499
3. registered for an event -
(3a) got an "invalid argument". . . for lines 658 and 691
(3b) order completed
4. checked 'store/orders/view' and found the order successful
5. checked event, no new registration for the information I used
6. checked email, got registration email

and I like your comment on line 651 . .

Three times is a charm

A buddy of mine who is a Drupal developer spent some time with me on this. What we found is that signups are being registered in uc_signup_log for the temporary placeholders. However, upon payment completion (we think), a signup is being created in signup_log but the uid column isn't being populated, it was filled with zeroes.

We found many initiated signups in the uc_signup_log and only a few (those that were completed) in the signup_log. So when you go to check for signups in the user_admin_list, there are signups but they are not associated with a particular user or email. He wrote a custom module to do this as a temporary fix, which is basically a query that updates the signup_log table with the info from the uc_signup_log file upon completion of an order. The text of the module is as follows:

<?php
function custom_signup_convert($order_id){
//check the signups associated to orders but noit to users
watchdog('custom', "order_id: ".$order_id);
db_query("UPDATE {signup_log} set uid = (SELECT uid FROM {uc_signup_log} WHERE sid = signup_log.sid) WHERE uid = 0 AND sid IN (select usl.sid FROM {uc_signup_log} usl, {uc_orders} uo WHERE uo.order_id = usl.oid AND uo.order_status = 'completed' AND usl.oid = %d)", $order_id);
return;
}

In it you'll also find a watchdog to verify whether and what's working (whatever that means). We also linked this by some custom php code to execute the module in a conditional action aptly titled: "Update temp signups on checkout complete when order has no payment"

Apparently he reasoned what i reasoned in #4 point 1 above, which is that the trigger for what was working in Beta3 was 'checkout_complete' whereas the trigger in the dev build is 'payment_entered'. And as I'm using freeorder and my events have no charge, no payment is rendered etc.

And, looking at the code a little more, I see your comment on 958 "//TODO:save this in the order" - lmao!!! actually, you have the same line on 854 of the working beta3 so that's not it . . . On further comparing that with the beta3 i see lotsa changes in the function uc_signup_mark_paid area but don't understand it . . . did i mention that i'm not a coder(yet)?