This is what I'm noticing...

  1. To effectively use the Block menu method, you must define the class, "activeSlideMenu".
  2. To use the selector method you must define, "activeSlide".

Is that by design? If so, I can document.

The following oddities, which don't always cause problems... make things a bit less stable and could cause problems depending on the css in use:

  1. When using the menu block method (which requires css for "activeSlideMenu"), "activeSlide" is added as a class to the "ul" parent, but only when the second slide is displaying.
  2. "activeSlide" is added as a class to the "h2" for the title of the menu block, but only for the first slide is displaying.

When using "selector" method (which requires css for "activeSlide"), the class "activeSlideMenu" is added to the first "li" in the list.

I tested slideshows using three and four slides.

Thanks so much for the great module.

Shai

CommentFileSizeAuthor
#2 910360-active_pager-1.patch701 bytesredndahead

Comments

Shai’s picture

Shai commented

For those not super familiar with this module, when I say, "you must define" in the first two points, I mean, "You must define a class in your css."

Shai

redndahead’s picture

redndahead commented
Status: Active » Fixed
StatusFileSize
new 910360-active_pager-1.patch701 bytes

I committed a fix for this. Sorry for the super long delay on such a simple fix. The patch that was committed is attached.

Shai’s picture

Shai commented

I'll check it out. Does the documentation change at all, can you now use the same css selector whether using the block-menu or the selector method.

Thanks much,

Shai

redndahead’s picture

redndahead commented

They should both use activeSlideMenu

Shai’s picture

Shai commented

Great, thanks.

I see the commit in CVS but the version on the project page hasn't yet. It's been nine hours, I thought it was refreshed more often than that...

Shai

redndahead’s picture

redndahead commented

Dev releases happen once every 24 hours. Only tagged releases happen every 2 hours.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.