Hi,
When editing a node with one or more attached images, and then using 'preview', no images are shown for the teaser preview, but they are shown for the full node preview. This is similar to the previous problem in #630546: Attached image not shown in edit preview but due to the code-rework it has reappeared and needs to be solved in a slightly different way.

The cause is exactly the same, ie that the array of attached image ids is zero-keyed when viewing the node normally but it is keyed with the iid value during edit. For the teaser, only the first image is required and the function _image_attach_node_load_attached() currently takes $attached_nids[0]. This is empty during node edit. I suggest that using array_shift($attached_nids) will return the desired first iid regardless of how the array is keyed.

The attached screen grabs show the value of $attached_nids in _image_attach_node_load_attached() for the three different scenarios. Patch to follow.

Jonathan

CommentFileSizeAuthor
#3 910370-2.image_attach.show_image_in_edit_preview.patch1.52 KBjoachim
#2 _image_attach_node_load_attached EDIT PREVIEW.jpg134.89 KBjonathan1055
#1 _910370.image_attach.show_image_in_edit_preview.d6.patch1.16 KBjonathan1055
_image_attach_node_load_attached EDIT PREVIEW.jpg45.92 KBjonathan1055
_image_attach_node_load_attached TEASER VIEW.jpg37.28 KBjonathan1055
_image_attach_node_load_attached FULL NODE VIEW.jpg57.93 KBjonathan1055

Comments

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new _910370.image_attach.show_image_in_edit_preview.d6.patch1.16 KB

Here's a patch against beta6.

Jonathan

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new _image_attach_node_load_attached EDIT PREVIEW.jpg134.89 KB

Here is a better screen grab showing the array of image ids used during edit-preview. The call to the full node preview is done first, even though the results of the preview are often shown the other way round, with the teaser preview before the full node preview.

joachim’s picture

joachim commented
Status: Needs review » Fixed
StatusFileSize
new 910370-2.image_attach.show_image_in_edit_preview.patch1.52 KB

Thanks for the patch.

I've committed the attached -- just a few changes to the comments.

#910370 by jonathan1055: Fixed attached image not shown for teaser in preview.

jonathan1055’s picture

jonathan1055 commented

Excellent.
Thanks Joachim.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.