By Boinng on

I've just upgraded from 4.7.3 (actually 4.7.2 with the single security fix applied) to 4.7.4, and discovered a problem with the custom profile fields I had set up.

As an example - I had a "Location" field, which users completed with their, erm, location. Clicking on that location on their user page would then go to a "Other members from location" page, listing that user and any others with the same location.

Since the update, clicking on the location (or any other custom entry) brings up the same page but with a broken title (both in the title bar and on the page) of "Other members from <em>location</em>" - ie, displaying the <em> tags - and since (I'm guessing) those tags are also included in the search string, no users are matched or listed.

The admin log gives the following error message -

Unknown column '$query' in 'where clause' query: SELECT u.uid, u.access FROM users u INNER JOIN profile_values v ON u.uid = v.uid WHERE v.fid = 12 AND $query AND u.access != 0 AND u.status != 0 ORDER BY u.access DESC LIMIT 0, 20 in /home/boinng/public_html/includes/database.mysql.inc on line 121.

Since I didn't do the full upgrade before it's possible this occured under 4.7.3 as well, but if it's been mentioned before I can't find any reference to it anywhere. Can anyone help?

⋅ Categories: Drupal 4.7.x

Comments

Boinng’s picture

Boinng commented

I should mention, the address string being passed is still perfectly valid - ie, http://www.boinng.com/profile/profile_location/Petersfield - no <em> tags in sight.

vm’s picture

vm commented

4.7.4 introduced a bug. which has been patched see http://drupal.org/node/90062

you can apply those patches and fix this issue.

Boinng’s picture

Boinng commented

Thanks for pointing that out - the patch has worked perfectly.

Sorry to have started an unnecessary extra thread on the same subject, but I really did search for a solution first, and the above just didn't show up :(

vm’s picture

vm commented

issues wont on a search, you would have to go to the issues area first. http://drupal.org/project/issues : ) or use the advanced search form http://drupal.org/search/node and check off issues : )

blalond’s picture

blalond commented

I applied the patch from http://drupal.org/node/90062.
That made the browse profile by field work, but I still had <em> </em> around the field title.

I went into profile.module and made a simple change in profile_browse().
The $title was getting sent to check_plain() which was converting <em> to &lt;em&gt;
Here's the change in context:

    $output .= '</div>';

    // old line 463: drupal_set_title(check_plain($title));
    drupal_set_title($title);
    return $output;
  }
  else if ($name && !$field->fid) {
    drupal_not_found();
  }

So now, for instance, when people try to browse users from custom field "Location" they get the title "People from Location" instead of "People from <em>Location</em>"