Reproduce: Have a default menu link exported from features with a parent that is added via hook_menu (for example) and not hook_menu_default_menu_links.

Since this doesn't test if menu item is managed by a feature. 

if (!empty($link['plid']) && $parent = menu_link_load($link['plid'])) {
  $link['parent_path'] = $parent['link_path'];
}

When menu_links_features_rebuild_ordered is reordering, it drops the menu item as both conditions always fail.

Patch tests and lets it catch the first if statement. Later, if the menu item exists, even if not managed by features, it sets the parent as features_menu_link_load doesn't care who made the menu link :)!.

CommentFileSizeAuthor
#6 features_910604_menu_parent_path.patch748 byteshefox
#2 features.910604.patch740 bytesjhedstrom
parent_path_fallback.patch916 byteshefox

Comments

hefox’s picture

hefox commented
Title: parent_path set to links not managed by features causes menu link to not revert » parent_path set to path not in hook_menu_default_menu_links causes menu link to not revert

Clarifying title

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new features.910604.patch740 bytes

This resolves the issue for me. Re-uploading the same patch, but made with --relative --no-prefix so it can be applied via drush make.

hefox’s picture

hefox commented
Status: Needs review » Reviewed & tested by the community

Seems good then, marking RTBC.

(Oh damn, I've been sooo good lately about --relative --no-prefix I haven't been double checking my patches. I really need to make an alias...).

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

+1. This, and a few others, have resolved some crazy menu problems I was having. Thanks!

hefox’s picture

hefox commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Code in d7 looks the same

d6 commit: http://drupalcode.org/project/features.git/commit/9f4c8e4

hefox’s picture

hefox commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new features_910604_menu_parent_path.patch748 bytes

Patch applied fine, so here's one with the a/, b/ prefixes.

febbraro’s picture

febbraro commented
Assigned: Unassigned » febbraro
febbraro’s picture

febbraro commented

I'm having difficultly testing this. Can you give me a more complete test case?

hefox’s picture

hefox commented

1) Take a menu item that is in a menu by default, like create content (node/add) in navigation.
2) Add a menu entity under that to something else ('admin/content/node'? for example)
3) export that menu link into a feature.
4) try that feature on a new site

(I think)

mpotter’s picture

mpotter commented
Status: Needs review » Closed (won't fix)

Closing this for lack of activity. I know menu links have issues, but please re-open this issue if you think this patch is still needed.