http://wiki.developers.facebook.com/images/1/17/Connect_light_small_shor... is no longer available from the Facebook site. This results in a broken image on the add to facebook item.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | fbconnect_stream_favicon.patch | 1.82 KB | jcmarco |
| #1 | Connect_white_small_short.gif | 379 bytes | MikeSSC |
Comments
Comment #1
MikeSSC commentedI noticed this as well and put a copy of the image in the module directory and altered the code to point to it instead.
Comment #2
vectoroc commentedComment #3
vectoroc commentedfixed in github
Comment #4
jcmarco commentedThere is an alternative to the original wiki image, and it is using the actual FB favicon.
This is better in terms of performance and it is likely the same than original version.
The inconvenience is that it could change in the future again, as it is not an official resource.
For your review and decision.
Comment #5
jcmarco commentedThe patch to review
Comment #6
vectoroc commentedactually there is an local image
Comment #7
jcmarco commentedI realized with that.
This patch, as I said, it an alternative with best performance,
it doesn't fix anything else than using a different facebook favicon and not using a theme function to show an icon with a hardcoded weird clear line at the button, that not allow be replaced.
If you like I could make this patch in a different way, as:
- add a custom theme function that show that icon, what would allow to customize that favicon.
- or/and, Add the option in a admin form to show a local favicon or a configurable url with the remote favicon.
Comment #8
vectoroc commentedanyway I dont like to copy facebook icon into fbconnect module.
There is few issues:
- use http/https protocol depends on where you are
- load icon from facebook.com domain (http://facebook.com/images/connect_favicon.png works too)
because https://static.ak.fbcdn.net/images/connect_favicon.png says that certificate is granted for facebook.com
http://github.com/vectoroc/fbconnect/commit/39b3dcef9a2c7efc5e870057d18a...
Comment #9
jcmarco commentedGreat! Thank you
Comment #10
jcmarco commentedThere is a typo in the theme_stream_publish_favicon() function:
There is an extra " after adding $protocol, it should be this way:
Comment #12
gobinathmClosing the issue. It was inactive for a long time & it's related to a Drupal Version which is not supported anymore