http://wiki.developers.facebook.com/images/1/17/Connect_light_small_shor... is no longer available from the Facebook site. This results in a broken image on the add to facebook item.

Comments

MikeSSC’s picture

StatusFileSize
new379 bytes

I noticed this as well and put a copy of the image in the module directory and altered the code to point to it instead.

vectoroc’s picture

Category: bug » task
Priority: Normal » Major
vectoroc’s picture

Status: Active » Fixed

fixed in github

jcmarco’s picture

Status: Fixed » Needs review

There is an alternative to the original wiki image, and it is using the actual FB favicon.

This is better in terms of performance and it is likely the same than original version.
The inconvenience is that it could change in the future again, as it is not an official resource.

For your review and decision.

jcmarco’s picture

StatusFileSize
new1.82 KB

The patch to review

vectoroc’s picture

actually there is an local image

jcmarco’s picture

I realized with that.
This patch, as I said, it an alternative with best performance,
it doesn't fix anything else than using a different facebook favicon and not using a theme function to show an icon with a hardcoded weird clear line at the button, that not allow be replaced.

If you like I could make this patch in a different way, as:
- add a custom theme function that show that icon, what would allow to customize that favicon.
- or/and, Add the option in a admin form to show a local favicon or a configurable url with the remote favicon.

vectoroc’s picture

anyway I dont like to copy facebook icon into fbconnect module.

There is few issues:
- use http/https protocol depends on where you are
- load icon from facebook.com domain (http://facebook.com/images/connect_favicon.png works too)

because https://static.ak.fbcdn.net/images/connect_favicon.png says that certificate is granted for facebook.com

http://github.com/vectoroc/fbconnect/commit/39b3dcef9a2c7efc5e870057d18a...

jcmarco’s picture

Great! Thank you

jcmarco’s picture

There is a typo in the theme_stream_publish_favicon() function:
There is an extra " after adding $protocol, it should be this way:

return '<img src="'. $protocol .'facebook.com/images/connect_favicon.png" />';

  • vectoroc committed e1b53c9 on
    #923268 : added Rule for Friend Invite #911432 : added fb icon to strem...
  • vectoroc committed c3a5041 on
    #766920 by mvc : added theme functions for user profile tab #911432 by...
gobinathm’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)

Closing the issue. It was inactive for a long time & it's related to a Drupal Version which is not supported anymore