This patch refactors the theme('content_moderation_node_history') function to use a template file instead of the theme_hook() function.
| Comment | File | Size | Author |
|---|---|---|---|
| content_moderation.history_theme_refactored.patch | 3.16 KB | dparks |
This patch refactors the theme('content_moderation_node_history') function to use a template file instead of the theme_hook() function.
| Comment | File | Size | Author |
|---|---|---|---|
| content_moderation.history_theme_refactored.patch | 3.16 KB | dparks |
Comments
Comment #1
eugenmayer commentedWell eventhough i see that your path cleans up the code a bit, moving the logic to the preprocess method.. i ask myself, if it is really worth in letting drupal load a file (tpl) just for this simple line? Thats just one more I/O call...
...
but on the other hand, this patch gives everybody the ability to change the way it looks like AND the way it gets computed, e.g. adding some bulk methods. I take that one in for 1.6, once again great work dparks, thanks!
Comment #2
eugenmayer commentedincluded in 1.6. Thanks you!