The height of my iframe is to long. To be exact 16px. See screenshot.

CommentFileSizeAuthor
modalframe-iframe-to-long.png36.21 KBMichsk

Comments

markus_petrux’s picture

Status: Active » Postponed (maintainer needs more info)

Does that necessarily mean there's a bug in the Modal Frame API?

It looks like you're doing complex stuff here, so there may be something that you need to take into account, or... maybe something else.

A screenshot does not tell much about what are you doing.

Michsk’s picture

Complex? Nothing complex going on here, just some simple theming. So yeh sure it could be something else but i don't think it is since parent.js sets the height for the iframe and it's just 16px to tall. But seems your to busy. Never mind.

markus_petrux’s picture

I do not have the time to analyze your issue, but I can review it if you can tell me where the bug is, and even better if you can provide a patch to fix it.

I would feel happy if you can use something I've done in your project. However, I cannot do everything for you. Or you may find other tools out there that better suit your needs, or you can even build your own. No option is perfect, I know.

There could be a bug, maybe in the place where the height option of the Modal Frame is translated into CSS properties, etc. of the components behind the scenes...

But maybe there's something that your doing that needs some other custom action so that this difference in height can be adjusted. One thing is the height of the iframe, another one is the height of the container of the modal frame, which also has a title bar, etc.

giorgosk’s picture

I have the same problem but its not necessarily the module's bug

I have the feeling that when scrollbars are introduced (overflow: auto; or overflow: scroll;) the height of the container increases by 16px which is probably the height of the scrollbar arrow-down-button ??!!!

Michsk’s picture

That sounds very plausible, also when looking at the screenshot provided in the first post.

dsnopek’s picture

Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (works as designed)

This sounds like a bug in the theme. Some themes don't work correctly when the page.tpl.php is swapped out for modalframe-page.tpl.php and require some additional CSS to fix the problems. Unfortunately, modalframe can't anticipate everything any theme could do. :-)