I installed this module yesterday with the anticipation of using it in the future. I started getting emails from my users today complaining that the site was acting weird. It took me a while to figure it out, but I had set 'endure misery' permissions on Authenticated users! At the time, I thought this meant 'allow this role to have endure misery to be set to it', rather than 'everyone in this role endures misery'!

My own fault of course for setting this without checking, but to save this happening to someone else at some point in the future, it may be helpful to change the name to 'always endure misery'.

Comments

danielb’s picture

danielb commented

Unfortunately changing the name will cause upgrade issues, since permissions have no ID other than the name of the permission

jaypan’s picture

jaypan
Location Victoria, BC
commented

That's true, though the worst that will happen is that some group who is suffering misery all of a sudden won't be.

jefkin’s picture

jefkin commented

You could fix that in your upgrade, do a update on the permissions table changing rows with the old name to have the new name, not difficult at all unless you need some help with the mysql.

danielb’s picture

danielb commented

good point

jaypan’s picture

jaypan
Location Victoria, BC
commented

In retrospect, I don't even think this should be in the permissions table at all. This isn't something you are giving permission for, it's something that you are punishing with. It should be removed from the permissions table altogether and put on a settings page.

danielb’s picture

danielb commented
Status: Active » Fixed

Good idea, done.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.