I didn't tagged this issue as "need review" because the bug is really obvious and needs to be fixed very quickly.
Actually, the header of send_nodeapi() are wrong, probably due to a too-fast copy-paste :-).

The result is:
- the function does not work as expected
- if a module calls directly nodeapi (e.g.: apachesolr_search) and specify any literal argument as second or third argument, a PHP fatal error is thrown...

CommentFileSizeAuthor
send-nodeapi-hook-header.patch971 bytesb-prod

Comments

b-prod’s picture

b-prod commented

The patch removes also an extra space at the end of line 109 (automatic correction by my PHP editor), and I left the fix in patch above, because it has no sense to open an issue only for that.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Confirmed. This bug is causing a fatal error and preventing indexing in apachesolr.module, which directly invokes hook_nodeapi():

Fatal error: Cannot pass parameter 2 by reference in /home/svn-working/drupal/branches/6.16-sites/all/modules/apachesolr/apachesolr.index.inc on line 54
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Yes, the patch fixes the bug. Yes, it's a critical bug as it can kill a site (in combination with other code, like that in apachesolr.module).

allie micka’s picture

allie micka
she/her
commented
Status: Reviewed & tested by the community » Fixed

Gah! fair enough. Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

qasimzee’s picture

qasimzee commented

I don't think it's still available in the stable release. Is it?