Patch's attached.

CommentFileSizeAuthor
#7 913474-node_edit_link_should_not_appear_when_not_editable-7-D6.patch2.56 KBamateescu
#7 913474-node_edit_link_should_not_appear_when_not_editable-7.patch3.01 KBamateescu
#4 913474-node_edit_link_should_not_appear_when_not_editable-D6.patch2.38 KBamateescu
#4 913474-node_edit_link_should_not_appear_when_not_editable.patch2.6 KBamateescu
#1 913474_nodequeue_edit_link_permission.patch1008 bytesaron novak
nodequeue_edit_link_permission.patch1006 bytesaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new 913474_nodequeue_edit_link_permission.patch1008 bytes

The previous one is bogus, 'edit' op does not exist, only 'update'.

jaydub’s picture

jaydub commented
Status: Needs review » Reviewed & tested by the community

Patch looks good and applies cleanly.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Needs work

the 'update' parameter of node_access needs more information about the node than what's in the node table. We should provide that information, probably with nodequeue_load_nodes().

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new 913474-node_edit_link_should_not_appear_when_not_editable.patch2.6 KB
new 913474-node_edit_link_should_not_appear_when_not_editable-D6.patch2.38 KB

Attached patches loads the full node in _nodequeue_dragdrop_get_nodes().

ezra-g’s picture

ezra-g commented
Status: Needs review » Reviewed & tested by the community

Thanks for adding the full node_load(). Seems RTBC to me!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

If you can, you should probably try to use node_load_multiple() if possible, but if you want to keep your branches in sync, then ok since it's really not that bad unless you have large nodequeues.

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new 913474-node_edit_link_should_not_appear_when_not_editable-7.patch3.01 KB
new 913474-node_edit_link_should_not_appear_when_not_editable-7-D6.patch2.56 KB

I don't have a strong preference to keep them in sync, and this is just a small change, so I commited the attached patches to 6.x and 7.x.

http://drupalcode.org/project/nodequeue.git/commit/1a57ec1
http://drupalcode.org/project/nodequeue.git/commit/8606fb2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.