[D6] Kosova

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

tagging as a theme review.

Hi Shemsedin,

Thanks very much for your work and interest in contributing to Drupal. It looks very nice. :-)

I'm not yet familiar with the full process for reviewing a theme, but I thought I would help by pointing out a few things that I noticed (not intended to be a complete list):

• I think there is a stray "td" in the page template (for sidebar-right) that was provided intended to be "div".
• In the node template, I personally think it would be more ideal to wrap variables like $submitted in a conditional like you have with $picture.
• I'm a bit confused with the login block section in the page template. Is the way it is right now for demo/display purposes only or intended to be included that way when the theme is released. There's a couple things related to this, but I thought I would just ask first.

Thanks again. I think it's great to get some more themes added to Drupal to help compliment what is available within certain styles and use cases.

Sincerely,

Matt Winters

Hi Shemsedin,

I understand about the log in block - it can make for a good experience to have such. I just don't know that the existing code would work for a Drupal log in. I could be wrong; perhaps someone else can advise on this. My understanding of various Drupal forms in that there are additional elements - form IDs, etc. that are generated.

But also a default Drupal installation does have a log-in block than can be assigned to a block region via the Block settings page. So perhaps styling that (if needed / preferred) would be a good way to go.

Speaking for myself personally, I think everything I mentioned were just things I noticed and suggestions. I only recently started volunteering some time here, so I'm not an expert on the CVS application process. But I don't think - again personally - that the items I listed really fall under things that would impeded obtaining CVS access. They were just observations and suggestions.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

Shemedsin:

Please review what is needed in 'Migrating from CVS Applications to (Git) Full Project Applications'

Specifically, you need to create a new sandbox project to hold your code, instead of placing it in a .zip file in your git application.

Resetting to 'postponed' until code is properly presented.

Hi Shemsedin,

Sorry for the really, really long delay here and hoping maybe you have another issue going on the project applications queue (successor to this cvs app queue) because it seems we've really dropped the ball on checking in here. My apologies, again.

For review to continue, you need to create a sandbox with your code as described here, using Git, then you can set this issue back to "needs review".

Thanks.

_{benjamin, agaric}

One last missing step ... as per 'Migrating from CVS Applications to (Git) Full Project Applications', this application needs to be moved over to the Git Project Application queue in order for it to get reviewed after the Git Migration.

I've moved it over into the proper queue for you, so it should now get some review attention.

I've also marked it as 'needs work' ... please add a comment to this thread, containing a link to the specific Sandbox project page that you want us to review; and then set the status of this application back to 'needs review'.

Shemsidin,

As per the instuctions in #10, relinked in #12, and re-explained in #15, you need to provide a link to the sandbox which contains the code you want reviewed. Reviewers can't review the theme unless you provide a link to the theme.

The instructions you need to follow were included in the link in comment #10. When you didn't follow those instructions, I did it for you in #15 and 16 ... and told you exactly what needed to happen to get the project reviewed. Those comments are still valid.

With regards to changing the project name, once the application is approved, you will have a chance to change the project shortname while promoting it to a full project.

http://drupalcode.org/sandbox/Shemsedin/1107290.git should be enough.

Now, unfortunately, it's back to the waiting game until someone picks up the application for review once again. This may be anywhere from 1 to 4 weeks, but hopefully on the shorter side of this window.

I suspect your application has been picked up a number of times in the past, but because there was no sandbox link, I'm speculating that the reviewers would simply have moved on to the next application. Now that this is corrected, it shouldn't get skipped next time.

Unfornately, I haven't been doing any theme reviews myself ... but I'm sure a theme reviewer should be along shortly.

It looks like there are two additional copies of the sandbox:

http://drupal.org/sandbox/Shemsedin/1083036
http://drupal.org/sandbox/Shemsedin/1084124

To avoid further review confusion, I'd suggest changing the descriptions of those to link to the project we're actually reviewing:

http://drupal.org/sandbox/Shemsedin/1107290

I did a very quick review of the code in Git (haven't installed it yet) and opened a couple issues in the project issue queue. Please move this back to "needs review" when those are resolved.

Those files are still on Drupal.org. I'm guessing you need to do git push. There are instructions in the "Version control" tab explaining how to do that. You'll need to become familiar with Git to effectively maintain projects on Drupal.org, so this is a good time to practice.

I think only site administrators can delete projects, but you can link from the other projects to the main project.

Per comment #28 I removed the two sandboxes that are not the good one:
http://drupal.org/sandbox/Shemsedin/1107290

The primary links seem to be hardcoded to index.html services.html and contact.html and there are a bunch of links to oxweb in the top right which should instead be tied to the Drupal menu system.

http://drupalcode.org/sandbox/Shemsedin/1107290.git/blob/refs/heads/mast... should remove windows new lines and instead use unix line endings.

The applicant has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Got contact with Shemsedin, the application is not abandoned.

Hi, I could not test right now, but I did a manual review of the code. If you have any questions regarding this, please ask.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

README.txt

The file should wrap at 80 columns

kosova.info

Remove the extra newline in the end, your file should end with one empty newline.

kosova.js

There are functions that are commented out, if they are not going to be used, please remove them. You have two extra newlines in the beginning of the file (remove), and missing one in the end (add). Also you have one version of the file in js, and another one in the main folder. You should remove the wrong one.

block.tpl.php

File begins with empty <? ?>, please remove, or better, add comments about the file.

box.tpl.php

File begins with empty <? ?>, please remove, or better, add comments about the file. One extra newline at the end, please remove.

comment.tpl.php

File begins with empty <? ?>, please remove. or better, add comments about the file.

ie6.css

File beginns with empty newlines, please remove them.

node.tpl.php

File begins with empty <? ?>, please remove. or better, add comments about the file.

page.tpl.php

File begins with empty <? ?>, please remove. or better, add comments about the file. You have commented out bits of the code, if the code is not going to be used, please remove it. You have a lots of extra newlines in the end of the file. Please remove them.

style.css

File starts with extra newline, please remove. Please add a new line in the end of the file, and remove the extra lines between your declarations.

images

You have a bunch of images here - how you created them, or how is they licensed?. Also it is a mix of png and gif, why?

Ran through the Drupal Code Sniffer and it reported the following problems http://ventral.org/pareview/httpgitdrupalorgsandboxshemsedin1107290git

@sankatha woaahhh, please don't paste raw reports into issues look how clumsy that is! ;-)
please edit your comment and provide a link instead!

// edit, Thanks! :)

Hi,
I just set your theme and I found some layout collapsed. See screenshots.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

You need to set the status to "needs review" if you want to get a review. See http://drupal.org/node/532400

The code could definitely use some cleanup - I recommend you check out https://drupal.org/coding-standards. You also seem to have kosova.js ducplicated in both the root and js/ folders. You should add a README.txt file in the root directory.

There don't seem to be any major issues though, marking RTBC.

Hi Shemsedin,

Only a few years into the process, with both you and reviewers including sreynen, Misc, and kscheirer moving it forward at long intervals, you've demonstrated sufficient quality of code and proficiency with Git to join the ranks of vetted Git users, the project maintainers. Congratulations!

The Git instruction tab on your project is one of your new best friends, and continue to address issues in the project queue as you did with sreynen's. Thanks so much for your continued contributing!

@mlncn: please use the promotion template from https://groups.drupal.org/node/184389 :

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.