Hello,

After the installation of Drupal 7 Alpha7, and i run the cron for the first time, the message returned by the execution is "Cron ran successfully".

I think is "Cron run successfully"

Best regards,
Sebastien

CommentFileSizeAuthor
#3 cron-message-913956.patch512 bytesdevin carlson
drupal-D7.patch692 bytessebyoga

Comments

webchick’s picture

Version: 7.0-alpha7 » 8.x-dev
Status: Patch (to be ported) » Needs work

Thanks for the patch!

I think it would either be "Cron run successful" or "Cron ran successfully" (the current string). Both "Cron run" and the shortened "Cron" are nouns.

"Cron run successful" would have better parity with the error equivalent -- "Cron run failed" -- but I don't think we can justify breaking strings for this, since it's not really a bug, per se. Moving to 8.x for consideration.

sebyoga’s picture

Hello,

Thank you for your return, indeed, it is not one really a bug. I suppose that il will also be corrected for Drupal 7 ?

I am going to continue to correct certain bug.

Thank you !

Sebastien

devin carlson’s picture

Assigned: sebyoga » Unassigned
Status: Needs work » Needs review
StatusFileSize
new512 bytes

Updated per webchick's recommendation (which I agree with) but I believe that it should be "Cron run was successful." in order to be proper English and to match the past tense of "Cron failed".

droplet’s picture

Component: system.module » user interface text
Issue tags: +Quick fix, +Novice
derjochenmeyer’s picture

I guess a native english speaker should review this. "Cron run succeeded." sounds weird, but may be correct.

bhosmer’s picture

The cron run was successful or Cron ran successfully for the affirmative and The cron run failed or The cron run was unsuccessful would be proper English.

Or to simplify: "Cron failed" and "Cron succeeded without errors" maybe?

Anonymous’s picture

"Cron run was successful" or "Cron ran successfully" would be good and more common English.

"Cron run succeeded." is Ok but sounds weird.

derjochenmeyer’s picture

Status: Needs review » Needs work

So I'd vote for closing "closed (works as designed)" this issue, since the current message is correct english:

drupal_set_message(t('Cron ran successfully.'));
derjochenmeyer’s picture

Status: Needs work » Needs review
yoroy’s picture

Status: Needs review » Closed (works as designed)

Yep, this was a small misunderstanding by sebyoga that didn't stop sebyoga from actually understanding the message, so nothing to fix here :)