This seems like this branch is just at the beginning of being worked on so I don't know how helpful this is, but I got the non-ajaxy tabs working for Drupal 7 Alpha 7 with the code changes reflected in the attached patch. (before the patch quicktabs was only rendering tabs which contained renderable arrays, but it would not render blocks that just delivered markup).
I didn't look at the ajax functionality for long because a) I don't really need it for what I'm setting out to do, and b) it was more broken than just needing to be rendered differently (though it will eventually need to be made to distinguish the type of renderable it has and pass the right parameter to hook_block_view like I did for the non-ajax).
Regards
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | quicktabs.module.patch | 1.45 KB | calebgilbert |
| quicktabs.module.patch | 1.99 KB | calebgilbert |
Comments
Comment #1
calebgilbert commentedHere is a much cleaned up patch that has less redundancy - what I should have posted the first time around. :P
Comment #2
BenK commentedTracking this thread...
Comment #3
dave reidConfirmed this fixed rendering for non-ajax display and the patch is sound.
Comment #4
katbailey commentedI will try to get to this at the weekend - sorry for taking so long and thanks for the patch!
Comment #5
rwohlebsubscribe
Comment #6
katbailey commentedI'm changing this to the 7.x-2.x branch as that's the one that is just a straight port from 6.x-2.x. The 3.x branch is likely to be a fairly drastic departure from this involving serious restructuring of the entire module.
Comment #7
netw3rker commentedComment #8
dave reid@netw3rker: Um, any explanation as to why this was marked won't fixed when it was reviewed and tested?
Comment #9
netw3rker commentedHi Dave :)
Sure:
1) It was demoted to a 2.x issue by @katbailey (in #6 about 4 years ago). 2.x support has been dropped
2) This was created when the 3.x line had just split off, and has since evolved dramatically and AFAIK resolved this issue.
As a heads up, I just got co-maintainer status, and am making a concerted effort to close out the 700 open issues and breathe some life back into this module. I've had to do some issue arbitrage and look at issues that are for unsupported branches/versions and in a lot of cases make the hard-call to just close it w/o a response.
If you think this is still relevant and can be rolled to the current 7.x-3.x or 6.x-3.x versions, I'm game for re-opening this, but a 4yrs old issue on a 2.x version is pretty much a dead issue in my book.