Performance issues with Sections module [#914480]

There are some serious performance issues with the sections module...

It implements hook_preprocess(), and in that, it calls _sections_in_section(), which does a database query. hook_preprocess() gets called many many times per page - which results in a huge number of database queries for every single page load.

Comment	File	Size	Author
#3	914480-sections-performance.patch	2.72 KB	mrfelton
#1	914480-sections-performance.patch	2.66 KB	mrfelton

Comments

Comment #1

mrfelton commented 17 September 2010 at 09:42

Status:

Active

» Needs review

Status	File	Size
new	914480-sections-performance.patch	2.66 KB

You'll need to apply the patch from #685736: Node theme doesn't take precedence over path based sections before applying this.

With that other patch applied, the sections determination is done in hook_init(). This only happens once, and once that has been run, we know what section we are in so there is no need to ask the database again. I have used a global to store the active section, and then in hook_preprocess(), we can simply look at the global to find out what section we are in, rather than asking the database again and again.