Closed (fixed)
Project:
TranslateThis Button
Version:
7.x-1.2
Component:
Miscellaneous
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2010 at 13:11 UTC
Updated:
31 Jul 2016 at 20:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
BarisW commentedGood point! I have to add a check to find out what you are using before fetching the CSS.
Instead of pointing to http://x.translateth.is/translate-this.js of have to point to https://x.translateth.is/translate-this.js instead.
I'll add it in the next release.
Comment #2
BarisW commentedComment #3
BarisW commentedAdded it to 6.x-1.x-dev.
Comment #4
mjh2901 commentedI checked the code and translatethis does have https (Fantastic) However in Chrome on the mac the button does not show up, so I started following the error, and it goes to a secure link on the tranlateth.is site for the https://x.translateth.is/trahslate-this.js file Chrome throws up a identity verify error and the red https we think this is evil thing. Which of course halts access to the translate-this.js file causing the entire universe to come crashing down.
Here is the error (Chrome on Mac OS X)
The identity of this website has not been verified
then
Your Connection to the x.translateth.is is encrypted with 128-bit encryption. The connection is encrypted using RC4_128, with MD5 for message authentication and RSA as the key exchange mechanism. The connection is not compressed. The server does not support TLS renegotiation extension.
I think this is chrome being over paranoid but its a problem.
I threw in a screenshot.
This is probably more a chrome issue than a module issue.
Comment #6
BarisW commentedThe author of the TranslateThis javascript wrote me that he has a technique in the works that will make https possible. Update will follow.
Comment #7
BarisW commentedComment #8
ajitsAny updates on the issue? I think the problem is the return statement in
As, this returns a link pointing to a resource which is on HTTP and not on HTTPS.
And I was able to get the JS file on https://x.translateth.is/translate-this.js (got the same error as #4 in chrome on windows).
Comment #9
donatasp commentedDoes anyone know if it is legal to put https://x.translateth.is/translate-this.js on own server so that https problem goes away?
Comment #10
Konstantin Komelin commentedFixed issue and updated the button code according to the latest code from https://www.translatecompany.com/translate-this/
The absolute HTTP url has been replaced with the universal one //x.translateth.is/translate-this.js
Patch attached. Please review.
Comment #11
Konstantin Komelin commentedComment #12
Konstantin Komelin commentedPlease also review the patch for Drupal 6.
Comment #13
Konstantin Komelin commentedOne problem though, It looks like the service (www.translatecompany.com) itself gives us HTTP-only links through its JavaScripts. So I'm considering move to https://www.drupal.org/project/gtranslate even if it has similar issues. Hopefully, we'll be able to fix them easier.
Comment #15
Konstantin Komelin commentedAny comments on why my patches were ignored?
Comment #17
BarisW commentedDon't know Konstantin, must have been a mistake. Thanks for the patch, I added it to the 7.x branch.
Comment #18
Konstantin Komelin commentedThank you Baris for reviewing and applying my patch!
Sadly, Drupal 6 patch does not make sense since Drupal 6 versions are not "legal" anymore.