I am finishing site the requires an SSL cert, and also requires translation, however when I place the button in the suckerfish menu I lose the secure connection.
I have a feeling because it is pulling from an outside source. Is there a way around this. The button works great but I need to secure the pages.

Thanks,
Frazier Scott

Comments

BarisW’s picture

Good point! I have to add a check to find out what you are using before fetching the CSS.
Instead of pointing to http://x.translateth.is/translate-this.js of have to point to https://x.translateth.is/translate-this.js instead.

I'll add it in the next release.

BarisW’s picture

Assigned: Unassigned » BarisW
BarisW’s picture

Assigned: BarisW » Unassigned
Status: Active » Fixed

Added it to 6.x-1.x-dev.

mjh2901’s picture

Version: 6.x-1.0 » 6.x-1.1
StatusFileSize
new133.59 KB

I checked the code and translatethis does have https (Fantastic) However in Chrome on the mac the button does not show up, so I started following the error, and it goes to a secure link on the tranlateth.is site for the https://x.translateth.is/trahslate-this.js file Chrome throws up a identity verify error and the red https we think this is evil thing. Which of course halts access to the translate-this.js file causing the entire universe to come crashing down.

Here is the error (Chrome on Mac OS X)
The identity of this website has not been verified

then
Your Connection to the x.translateth.is is encrypted with 128-bit encryption. The connection is encrypted using RC4_128, with MD5 for message authentication and RSA as the key exchange mechanism. The connection is not compressed. The server does not support TLS renegotiation extension.

I think this is chrome being over paranoid but its a problem.

I threw in a screenshot.
This is probably more a chrome issue than a module issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

BarisW’s picture

Status: Closed (fixed) » Active

The author of the TranslateThis javascript wrote me that he has a technique in the works that will make https possible. Update will follow.

BarisW’s picture

Status: Active » Postponed
ajits’s picture

Version: 6.x-1.1 » 7.x-1.1

Any updates on the issue? I think the problem is the return statement in

translate_this_display_button() {
  return '<div id="translate-this"><a href="http://translateth.is/" class="translate-this-button">' . t('Translate') . '</a></div>';
}

As, this returns a link pointing to a resource which is on HTTP and not on HTTPS.
And I was able to get the JS file on https://x.translateth.is/translate-this.js (got the same error as #4 in chrome on windows).

donatasp’s picture

Version: 7.x-1.1 » 7.x-1.2
Status: Postponed » Active

Does anyone know if it is legal to put https://x.translateth.is/translate-this.js on own server so that https problem goes away?

Konstantin Komelin’s picture

Issue summary: View changes
StatusFileSize
new1.3 KB

Fixed issue and updated the button code according to the latest code from https://www.translatecompany.com/translate-this/
The absolute HTTP url has been replaced with the universal one //x.translateth.is/translate-this.js
Patch attached. Please review.

Konstantin Komelin’s picture

Status: Active » Needs review
Konstantin Komelin’s picture

Please also review the patch for Drupal 6.

Konstantin Komelin’s picture

One problem though, It looks like the service (www.translatecompany.com) itself gives us HTTP-only links through its JavaScripts. So I'm considering move to https://www.drupal.org/project/gtranslate even if it has similar issues. Hopefully, we'll be able to fix them easier.

  • BarisW committed ed5a90a on 8.x-1.x
    Issue [#914694]: Cannot secure pages that include the Translate This...
Konstantin Komelin’s picture

Any comments on why my patches were ignored?

BarisW’s picture

Status: Needs review » Fixed

Don't know Konstantin, must have been a mistake. Thanks for the patch, I added it to the 7.x branch.

Konstantin Komelin’s picture

Thank you Baris for reviewing and applying my patch!
Sadly, Drupal 6 patch does not make sense since Drupal 6 versions are not "legal" anymore.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.