Closed (duplicate)
Project:
Drupal core
Version:
7.0-alpha7
Component:
database system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2010 at 14:39 UTC
Updated:
22 Nov 2010 at 23:15 UTC
In file includes/database/mysql/install.inc@25 there is a string, which is presented to user during installation.
/**
* Returns a human-readable name string for MySQL and equivalent databases.
*/
public function name() {
return 'MySQL, MariaDB, or equivalent';
}Should read:
/**
* Returns a human-readable name string for MySQL and equivalent databases.
*/
public function name() {
return st('MySQL, MariaDB, or equivalent');
}
Comments
Comment #1
David_Rothstein commentedProbably, yes.
Although I can see an argument for translating them only on display (i.e., like strings in hook_menu and other registry-style collections of information)? Then I guess the string extractor would need to learn about it, though.
In any case, it looks like it's not translated anywhere at all now, and that definitely seems like a bug.
Comment #2
Crell commentedCan we inform the translation system of these strings without using the t() function directly? That is yet another hard dependency on the translation system in the DB code, which we're trying to avoid.
Comment #3
wulff commentedCouldn't we solve this by only listing the major databases supported by a particular driver? In this case I think we could get away with just displaying 'MySQL, MariaDB'.
If other compatible databases show up, we can always add them to the list later.
Comment #4
tstoecklerI think at this point this is duplicate of #962458: Database driver names aren't translated.
Comment #5
Crell commentedIt's so much of a duplicate it even has the same issue name. :-)
Comment #6
David_Rothstein commentedOops, that was my fault :) When I transferred the issue name over there I thought this one had already been marked duplicate; I didn't realize it was still listed as active.
Comment #7
mahfiaz commentedWow, I wouldn't have believed these are *that* identical (minus the patch).