With the new file API in Drupal 7, file_directory_path() has been phased out. This probably has rather large implications for the XML Sitemaps module, since the code that deals with the XML-files will have to be completely overhauled.

Comments

mikl’s picture

Priority: Critical » Normal

Ah, this seems to be solved in HEAD. You should probably stop recommending the -beta1 release, since that is currently broken…

dave reid’s picture

Status: Active » Fixed

I cannot recommend dev releases but you are more than welcome to use them. I have a beta2 in the works but not until its ready.

billsdesk’s picture

I just test the beta1 release and am getting the same error. Given Drupal 7 is a work in progress, is it worth switching to the dev release of XML Sitemap?

billsdesk’s picture

Version: 7.x-2.0-beta1 » 7.x-2.x-dev
Priority: Normal » Critical
Status: Fixed » Active

I just tried to enable the module on D7 beta1 and am still getting the error. In fact, the blocks me from accessing the configuration menu. The module is once again disabled pending a fix.

billsdesk’s picture

Since I am using the dev version of almost every other module, I switched to the dev version for XML sitemap. So far, no problems. It appears that this problem is now fixed in the dev version.

dave reid’s picture

Status: Active » Fixed

@billsdesk: Yes I was confused since you changed the issue version to '7.x-2.x-dev' so on a quick glance I assumed you were actually using that version (so just make sure to double check which version you're reporting/changing against). Thanks for the update!

billsdesk’s picture

I had the problem with the beta1 version, but not the dev version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Brewski’s picture

Status: Closed (fixed) » Active

I'm having this problem with the beta

mikl’s picture

Version: 7.x-2.x-dev » 7.x-2.0-beta1

It is a bit confusing that 7.x-1.0-beta1 is a recommended release, given that it is not compatible with Drupal 7.0. The maintainer should probably remove the “recommended” until a new release can be made.

andycowl’s picture

Indeed. It also has the irritating consequence that when you are running '7.x-2.x-dev', Drupal 7.0 recommends a module upgrade to '7.x-1.0-beta1' which does not work.

Maybe the time has come to promote '7.x-2.x-dev' to '7.x-2.0-beta1' to prevent this happening.

Sylvain Lasnier’s picture

Is there a patch for this critical issue?

teiko’s picture

I fixed in xmlsitemap.module:
Line 975:
from : $directory = file_directory_path() . '/' . variable_get('xmlsitemap_path', 'xmlsitemap');
to: $directory = file_build_uri('xmlsitemap_path', 'xmlsitemap');

and in xmlsitemap.admin.inc:
Line 331 to:
'#field_prefix' => file_default_scheme() . ':/' ;

but sidemap could not be generatetd.
Adminconfiguration is on function

An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /batch?id=93&op=do StatusText: Internal Server Error ResponseText: PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'context_hash' in 'field list': UPDATE {xmlsitemap_sitemap} SET context_hash=:db_update_placeholder_0, context=:db_update_placeholder_1, updated=:db_update_placeholder_2, links=:db_update_placeholder_3, chunks=:db_update_placeholder_4 WHERE (smid = :db_condition_placeholder_0) ; Array ( [:db_update_placeholder_0] => 40cd750bba9870f18aada2478b24840a [:db_update_placeholder_1] => a:0:{} [:db_update_placeholder_2] => 1295521840 [:db_update_placeholder_3] => 1 [:db_update_placeholder_4] => 1 [:db_condition_placeholder_0] => NXhscRe0440PFpI5dSznEVgmauL25KojD7u4e9aZwOM ) in drupal_write_record() (line 6776 of BLABLABLA/includes/common.inc).

Hope this helps

sinav sonuclari’s picture

in xmlsitemap.admin.inc:
Line 331 to:
'#field_prefix' => file_default_scheme() . ':/' ;
Change;
'#field_prefix' => variable_get('file_public_path', conf_path() . '/files') . '/',

works well :)
Demo: Drupal 7 www.ozelguvenlike.com/sitemap.xml

mgifford’s picture

When is this going to be brought from dev to the recommended release so that we can use it?

elachlan’s picture

Yes, what is stopping dev being rolled into a second beta?

MarineFocus’s picture

An uninstall method posted would also be polite since it generates the same error. Personally I would like the function of the module but the problems exceed the need. Not being able to cleanly uninstall the tool makes it even more frustrating.

akamawa’s picture

Adopted changes made by Teiko (#13) and Aydinla (#14) and tested in D7 dev & production; results satisfactory...maybe urgently post an XML sitemap 7.x-2.0-beta 2 ???

or at least clearly mention the beta1 bug in the download-section to users so falling into the trap can be avoided, for (see #17 Marinefocus) this otherwise good module is rather difficult to completely uninstall. Saves a lot of time for everyone!

-nice job, teiko & aydinla! :)

dave reid’s picture

Status: Active » Fixed

I'm trying to roll a beta2 tonight. Please be patient.

mgifford’s picture

Thanks Dave!

dave reid’s picture

Beta2 is now out. Thanks for everyone's patience and sorry for the very tardy release.

mikl’s picture

Awesome work, David. Thanks :)

elachlan’s picture

Thanks David :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Daeluin’s picture

Status: Closed (fixed) » Active

I installed Beta2 and had the same issue - admin/config was broken, and I could not uninstall the module after disabling.

Tried an update to the dev version, pulled in the db updates, yet the issue remains.

Another copy of the site before I installed this module is working correctly.

Is there a recommended way to install manually?

Anonymous’s picture

Status: Active » Postponed (maintainer needs more info)

@Daeluin: Are you sure you are running the version of the module that you think you are? In other words you could have the module installed in sites/all/modules as well as sites/example.com/modules and the one being used isn't the one you think you've just installed.

Lindagail’s picture

I can confirm that I'm getting the WSOD at admin/config using the beta1, beta2 and dev versions of the module on my D7 site. Wondering if there is not a conflict with another existing module?

Anonymous’s picture

#27 Your WSOD issue isn't related to this issue. You'll need a different one. In the mean time read http://drupal.org/node/158043 and search "wsod drupal.org" for more information.

tlangston’s picture

Installed 7.x-2.0-beta3 and can confirm that this is happening on a 7.9 install. Not a WSOD but on Create, Edit nodes or Config of module itself I get 'The website encountered an unexpected error. Please try again later.'. There are no errors in the log.

dave reid’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)