Hey Aaron,
It was awesome to see this released recently as a separate module.
I've been following your great work on the Media module (http://drupal.org/project/media) for Drupal 7... any plans to release a version of Media: Vimeo that supports Media in D7?
Thanks!
--Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #40 | vimeo_api_thumbnails-915046-40.patch | 1.17 KB | Jackinloadup |
| #39 | vimeo_api_thumbnails-915046-39.patch | 1.17 KB | safetypin |
| #38 | vimeo_api_thumbnails-915046-38.patch | 27.47 KB | safetypin |
| #3 | media_vimeo.zip | 4.8 KB | Bevan |
Comments
Comment #1
aaron commentedyes, on the backburner for now...
Comment #2
Bevan commentedDoes that mean Vimeo module will depend on Media module (and not emfield module)? What is involved in porting Vimeo to D7/Media? Are there any modules for other providers like Vimeo (e.g. YouTube) that can be used as an example for this?
Related: #957544: EmField for Drupal 7?
Comment #3
Bevan commentedI started writing a Drupal 7 version of this that depends on Media Internet Providers module (in the Media package), based on the D7 branch of media_youtube. It is far from complete but is usable for some basic tasks, like adding a Vimeo video from the Media-picker by the URL of the Vimeo video page.
Comment #4
Bevan commentedI created the Vimeo Link Formatter module as a workaround for now. A number of code/features there will be re-usable in "Media: Vimeo" and we should merge these modules once "Media: Vimeo" is sufficiently mature.
Comment #5
steinmb commentedHi @Bevan :) Did you ever get a answer to your question in #2?
Comment #6
Bevan commentedKia ora Stein! (:
— #988954: Create upgrade path from Embedded Media Field (6.x) to Media module (7.x)
However, if you can't wait for that and it's Vimeo implementation (and can't contribute to them), then Vimeo Link Formatter provides features that are reduced but comparable to Drupal 6 "Media: Vimeo" module, but for Drupal 7, and not taking advantage of (or depending upon) Media nor stream wrappers. PM me for the code.
Comment #8
dmsmidtToo bad to have a workaround module, would be nice if it worked with the Media module.
Subscribe
Comment #9
aaron commentedsupport for media d7 is coming soon enough.
Comment #10
kmajzlik commentedsubscribing
Comment #11
drupalok commentedsubscribing
Comment #12
shinz83 commentedsubscribing
Comment #13
zberg007 commentedsubscribing
Comment #14
Jerome F commentedsubscribing (tired of subscribing ? http://drupal.org/node/34496 - http://3281d.com/2009/03/27/death-to-subscribe-comments)
Comment #15
vasikecould this be used for testing?
http://drupalcode.org/project/media_vimeo.git/shortlog/refs/heads/7.x-1.x
Comment #16
JGonzalez commentedsubscribing as well
Comment #17
zkrebs commentedsubscribing - i saw that the alternative way, using the vimeo link formatter, has a problem with views. how can one use the media module, and show the vimeo videos in views too - in d7?
Comment #18
perhenrik commentedsubscribing
Comment #19
Gr3fweN commentedsubscribing
Comment #20
jman77 commentedsubscribing
Comment #21
dpintats commentedsubscribing
Comment #22
so4 commentedsubscribing
Comment #23
rodych commentedsubscribing
Comment #24
kmajzlik commentedfor all subscribers: current hotfix = vimeo link formatter. works fine for me.
Comment #25
kreynen commentedI took a similar approach to @Bevan and just refactored media_youtube to work with peg.tv including the WYSIWYG support in http://drupal.org/project/media_pegtv. I need Vimeo support in Media and can put some time into media_vimeo. Would be helpful to have a D7 branch to work from.
@aaron any interest in opening the project up to additional co-maintainers for the D7 branch?
Comment #26
jerodfritz commentedsubscribing
Comment #27
sebish commentedsubscribing
Comment #28
midmood commentedsubscribing
Comment #29
Jackinloadup commentedsubscribe
Comment #30
aaron commentedthanks for the offer! i'm swamped these days, and rather than making everyone else suffer for it, i've added kreynen & Bevan as maintainers. you guys know the routine -- use issues & patches, and don't break anything if you can avoid it when committing, and please no broken releases...
thanks!
Comment #31
kreynen commentedCommitted a quick refactor of the current media_youtube. Works for Video with iframe embed when js is enabled. Haven't tested beyond that. This is far from done. This is commit is only for developers looking to get involved so we can divvy up the work.
Hoping to talk to @Bevan tomorrow.
Comment #32
zkrebs commentedI tried #31 and it indeed shows my video! However, the thumbnail preview for Media gallery and on the node edit page do not show.
Comment #33
Bevan commentedPlease remove me as a maintainer. I do not have time to contribute to this project sufficiently to justify being a maintainer. Thanks! :)
Comment #34
midmood commentedsubscribe
Comment #35
Jean Gionet commentedSubscribing
Comment #36
kioko commentedsubscribe
Comment #37
safetypin#31 did not work for me, at all. After some investigation, it looks to me like the video id is not being properly communicated to the theme function.
Correction:#31 did work for me. Problem was that I didn't use the video URL, and instead used the embed code, which the comments explicitly say it can't handle. Oh well.
Comment #38
safetypinThis is my first attempt at a patch, so please be gentle. On my local machine, I'm seeing thumbnails pulled from Vimeo.
Comment #39
safetypinI forgot that I changed another file, unrelated to this issue, so here's a cleaned up patch, for just the MediaVimeoStreamWrapper.inc file to make thumbnails work.
Comment #40
Jackinloadup commented@idlewilder Awesome patch works great!
I modified #39 to pull in the large thumbnail so I could build high quality thumbnail grids for videos.
I figure if we pull in the higher quality images the D7 image style utility will re-size it the way we want.
Thanks for the great work!
Comment #41
zigmoo commentedJust tested #39. Works great for me, too. Kudos to @idlewilder!
We need to get this patch committed to the module, and released for general use.
Comment #42
zigmoo commentedNice tweak, jackinloadup!
Comment #43
Jackinloadup commentedIt would be be great if kreynen could commit this to the 7.x-dev.
What else is needed to close this issue? Do we need to pull in titles? or is that part of media_browser_plus?
Comment #44
kreynen commentedI committed the patch from #40.
http://drupalcode.org/project/media_vimeo.git/commit/8665a94
I've set the dev snapshot for the 7 branch to display.
I'm closing this issue. I don't think the Drupal 7 branch is "done", but I hate tracking issue with a über heading like this. Instead, open a new issue specific to the problem and track the status of a patch using "needs review" and "community reviewed" statuses.