I wondered why can't simply expose Performance; improving the speed of Simpletest during development as configuration option?

CommentFileSizeAuthor
#12 D7-drupal-support_simpletest_table_engine-915922-12.patch5.8 KBpdrake
drupal.simpletest-mysql-engine.0.patch2.61 KBsun

Comments

moshe weitzman’s picture

moshe weitzman commented

Good idea, but it is a bit in your face for sites that don't use mysql

moshe weitzman’s picture

moshe weitzman commented

In other words, UI should only show for mysql sites.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

setting status according to #2

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Hm. I tested this only marginally, but based on limited testing on my local Windows box, I didn't see a substantial difference in test execution time when enforcing MyISAM. Perhaps it's only my box, which is actually very slow in many other ways. But before continuing with this patch, we should make sure that it actually makes a difference for someone.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: sun » Unassigned

In other words - since this does not lead to a performance increase for me, I'm not going to continue working on this patch, but which of course doesn't mean it couldn't be useful for others. I'll focus on #916570: Allow to run only certain test methods instead (and in general, making more tests use the testing profile).

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-dev » 8.x-dev
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

errr, why MyISAM in the first place? Tests should run using the MEMORY table engine!

Same patch, different engine.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

err, scratch that, chx rightfully clarified on IRC that the MEMORY table engine doesn't support BLOB/TEXT columns. Dang.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +Testing system
craigjones’s picture

craigjones commented

Following. In my experience, when I switched testing over to MyISAM it made a 3 fold difference in the time that tests took to complete, so being able to change it trivially is definitely advantageous.

xen’s picture

xen commented

I've just tested this, my findings:

The patch doesn't work on 7.15. It applies fine, and looks fine, but looking at the simpletest* tables while a test is running, they're still InnoDB...

As for the utility of the patch, when fixed: I am looking at this because I am trying to run two tests from services.module, which takes 45-55 minutes per default. Hardcoding MyISAM into includes/database/mysql/schema.inc, this is reduced to 10 minutes. A rather major improvement.

pdrake’s picture

pdrake commented
Status: Needs work » Needs review
StatusFileSize
new D7-drupal-support_simpletest_table_engine-915922-12.patch5.8 KB

I fixed the logic bug that prevented this patch from functioning. I also added the ability to choose the MEMORY table engine because various MySQL distributions (MariaDB 5.?, Percona 5.5) now support BLOB/CLOB columns. There are a few restrictions on column ordering and indexes, which are handled within the MySQL driver. This patch is for D7, will need a re-roll for D8.

Status: Needs review » Needs work
Issue tags: -Performance, -Testing system

The last submitted patch, D7-drupal-support_simpletest_table_engine-915922-12.patch, failed testing.

pdrake’s picture

pdrake commented
Status: Needs work » Needs review

#12: D7-drupal-support_simpletest_table_engine-915922-12.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Performance, +Testing system

The last submitted patch, D7-drupal-support_simpletest_table_engine-915922-12.patch, failed testing.

pdrake’s picture

pdrake commented

Oh, right, this issue is filed against D8 (obviously, this patch won't apply to D8).

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Project: Drupal core » SimpleTest
Version: 9.3.x-dev » 8.x-3.x-dev
Component: simpletest.module » Code
Issue summary: View changes

The simpletest module is obsolete in core. Moving to SimpleTest project.